Fix the PR image comment job - #583
leandroberetta wants to merge 1 commit into
Conversation
Since 12fc3df split the workflow into separate jobs, the comment job calls fs.readFileSync() without requiring 'fs' and no longer downloads the artifact holding ./commands-url, so it fails with "ReferenceError: fs is not defined". The image is pushed but no comment is posted, so PR authors and QE never get the image tag and fall back to :main. Read the URL in the push job, which already has the artifact, and pass it to the comment job as an output. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@leandroberetta: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
The
comment on PRjob ofpush_image_pr.ymlhas been failing since #12fc3df7 (Secure push job wrt branch interpolation) split the workflow into separate jobs:Two things were lost in that split: the
var fs = require('fs')line, and the artifact download step —./commands-urllives in theprartifact, which only thepushjob fetches.The effect is that the image is built and pushed fine, but no comment is posted, so PR authors and QE never learn the image tag. On #552 that led to QE running the PR's plugin script against
quay.io/netobserv/network-observability-cli:main(the default incommands/netobserv), whose binary does not have the newresolve-tlssubcommand, and the collector pod failed withunknown command "resolve-tls".Fix: read the URL in the
pushjob, which already has the artifact, and pass it to thecommentjob as a job output, in the same env-var style the rest of that script uses.Dependencies
n/a
Checklist
Note that this workflow can only be exercised by a real
ok-to-testlabel event, so the first labelled PR after this merges is the actual verification.🤖 Generated with Claude Code