[NAE-2452] Pre-release bugfixes

[renczesstefan]

Description

Fixes NAE-2452

Dependencies

No new dependencies were introduced.

Third party dependencies

No new dependencies were introduced.

Blocking Pull requests

There are no dependencies on other PR.

How Has Been This Tested?

This was tested manually and with unit tests.

Test Configuration

Name	Tested on
OS	macOS Tahoe 26.3
Runtime	Java 21
Dependency Manager	Maven 3.9.9n
Framework version	Spring Boot 3.4.4
Run parameters
Other configuration

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• My changes have been checked, personally or remotely, with @Retoocs
• I have commented my code, particularly in hard-to-understand areas
• I have resolved all conflicts with the target branch of the PR
• I have updated and synced my code with the target branch
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes:
  • Lint test
  • Unit tests
  • Integration tests
• I have checked my contribution with code analysis tools:
  • SonarCloud
  • Snyk
• I have made corresponding changes to the documentation:
  • Developer documentation
  • User Guides
  • Migration Guides

Summary by CodeRabbit

• Bug Fixes
  • Improved move behavior to determine the current parent and destination folder relationship up front, reducing the chance of brief inconsistencies during item relocations.
  • Refined folder-child updates so the parent-child links are only changed when the effective parent actually changes, keeping folder contents correctly synchronized.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0334e269-b829-445c-88ab-0f12ecfefaf0

📥 Commits

Reviewing files that changed from the base of the PR and between 4bef68f and a5e640e.

📒 Files selected for processing (1)

• application-engine/src/main/java/com/netgrif/application/engine/menu/services/MenuItemService.java

---

Walkthrough

MenuItemService.moveItem now resolves the destination parent up front, compares old and new parent ids, and only removes or updates parent cases when the parent actually changes.

Changes

moveItem Operation Order Fix

Layer / File(s)	Summary
moveItem reorder and rename application-engine/src/main/java/com/netgrif/application/engine/menu/services/MenuItemService.java	oldParentIdList is derived from the current parent list, newParent is resolved before relationship updates, and parentChanged gates removal from the old parent and updates to the new parent.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is generic and does not describe the actual code change, only a ticket ID and broad bugfix wording.	Rename it to reflect the main change, e.g. "Refine menu item parent update logic" or similar.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@application-engine/src/main/java/com/netgrif/application/engine/menu/services/MenuItemService.java`:
- Around line 271-273: Guard the move logic in MenuItemService so a no-op move
to the same parent does not reuse a stale `newParent` from
getOrCreateFolderItem(destUri). Check whether destUri matches the current parent
before calling removeChildItemFromParent() and appendChildCaseIdInMemory(), and
skip the append/update path when the source and destination parent are the same
to avoid duplicating the child ID on the parent.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c4d9e372-3d84-467b-be11-3a8bc1635e7c

📥 Commits

Reviewing files that changed from the base of the PR and between 9b1f1b9 and 4bef68f.

📒 Files selected for processing (1)

• application-engine/src/main/java/com/netgrif/application/engine/menu/services/MenuItemService.java

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
57.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud