chore(deps): upgrade conan dependencies by leoparente · Pull Request #784 · netboxlabs/pktvisor

leoparente · 2026-06-19T17:58:56Z

What

Upgrade Conan dependencies to current versions and fix the build issues the upgrades surfaced.

Upgraded

Package	From	To
catch2	3.14.0	3.15.1
libpcap	1.10.5	1.10.6
npcap (Windows)	1.70	1.86
opentelemetry-cpp	1.24.0	1.26.0
spdlog	1.15.0	1.17.0
libcurl	8.19.0	8.20.0
openssl	3.6.2	3.6.3
yaml-cpp	0.8.0	0.9.0
nlohmann_json	3.11.3	3.12.0
cpp-httplib	0.18.3	0.27.0

Also drops the explicit fmt/10.2.1 pin — fmt is now pulled transitively via spdlog (resolves to fmt/12.x).

Intentionally held back (dependency-graph / platform constraints)

protobuf stays 6.33.5 — opentelemetry-cpp/1.26.0 constrains protobuf/[>=4.25.3 <7], so 7.x conflicts in the graph.
openssl stays on 3.x (3.6.3) — a transitive dependency caps openssl at <4, so 4.0.1 conflicts.
cpp-httplib capped at 0.27.0 — from 0.28.0 the ConanCenter recipe unconditionally links libanl (non-blocking getaddrinfo) with no opt-out option; libanl does not exist on musl, which breaks the static musl cross-builds. 0.27.0 is the newest version that predates that recipe change.
nlohmann_json 3.12.0 uses force=True — opentelemetry-cpp and json-schema-validator pin an exact 3.11.3; the override is required to resolve the graph (header-only, API-compatible).

Build fixes required by the upgrades

OPENTELEMETRY_PROTO_API — opentelemetry-cpp 1.26.0 generates its protobuf headers with --cpp_out=dllexport_decl=OPENTELEMETRY_PROTO_API, but the Conan recipe does not propagate the macro to consumers. Defined in CMakeLists.txt: empty on macOS/Linux (static proto lib), __declspec(dllimport) on Windows (the Conan package builds proto as a DLL there).
#include <fmt/ranges.h> — fmt 12 no longer exposes fmt::join transitively, so the files using it now include it explicitly.

Testing

CI is green on all platforms: unit-tests-mac, unit-tests-linux, build-win64, both pktvisor musl cross-builds (x86_64 + aarch64), code-coverage, all pktvisor-cli variants, and CodeQL (Go + Python).

🤖 Generated with Claude Code

Bump: - catch2 3.14.0 -> 3.15.1 - libpcap 1.10.5 -> 1.10.6 - npcap 1.70 -> 1.86 (Windows) - opentelemetry-cpp 1.24.0 -> 1.26.0 - spdlog 1.15.0 -> 1.17.0 - libcurl 8.19.0 -> 8.20.0 Drop the explicit fmt/10.2.1 pin; fmt is now pulled transitively via spdlog (fmt/12.x). protobuf is intentionally left at 6.33.5: opentelemetry-cpp/1.26.0 requires protobuf<7, so a bump to 7.x is not currently viable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

leoparente · 2026-06-19T17:59:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b08b180854

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Mirror the libpcap force=True override for the Windows npcap requirement so the pinned version wins over any transitive constraint. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

opentelemetry-cpp 1.26.0 generates its protobuf headers with `protoc --cpp_out=dllexport_decl=OPENTELEMETRY_PROTO_API`. For a static build the macro must expand to nothing. Upstream defines it on the proto CMake target, but the Conan recipe does not propagate that definition to consumers, so the generated *.pb.h fail to compile in pktvisor (the macro is parsed as a stray type name, cascading into bogus protobuf errors). The generated headers are included from several targets (visor-core, handler unit tests, visor_test helpers), so define the macro globally. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

leoparente · 2026-06-19T18:20:48Z

@codex review

chatgpt-codex-connector · 2026-06-19T18:20:57Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

fmt 10 exposed fmt::join transitively, but fmt 12 no longer does, so every translation unit using fmt::join must include <fmt/ranges.h> explicitly. Add the include to the files that use it (GeoDB, StreamHandler, InputStream, DNS v1/v2 stream handlers, NetProbe input). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

leoparente · 2026-06-19T18:27:37Z

@codex review

chatgpt-codex-connector · 2026-06-19T18:27:44Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copilot

Pull request overview

This PR upgrades several Conan-managed dependencies (notably spdlog → 1.17.0 and opentelemetry-cpp → 1.26.0) and adjusts the build/source to stay compatible with the resulting transitive dependency changes (especially fmt moving to 12.x).

Changes:

Bump Conan dependency versions (catch2, libpcap/npcap, opentelemetry-cpp, spdlog, libcurl) and drop the explicit fmt pin.
Add #include <fmt/ranges.h> where fmt::join is used, to match newer fmt header requirements.
Add a global OPENTELEMETRY_PROTO_API compile definition to work around opentelemetry-cpp protobuf header generation/consumption behavior.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/StreamHandler.h`	Adds `fmt/ranges.h` include for `fmt::join` usage in header code.
`src/InputStream.h`	Adds `fmt/ranges.h` include for `fmt::join` usage in header code.
`src/inputs/netprobe/NetProbeInputStream.cpp`	Adds `fmt/ranges.h` include (fmt range/join support).
`src/handlers/dns/v2/DnsStreamHandler.cpp`	Adds `fmt/ranges.h` include (fmt range/join support).
`src/handlers/dns/v1/DnsStreamHandler.cpp`	Adds `fmt/ranges.h` include (fmt range/join support).
`src/GeoDB.cpp`	Adds `fmt/ranges.h` include for joining `sin6_addr` bytes.
`conanfile.py`	Upgrades dependency versions; removes fmt pin (left as commented line).
`CMakeLists.txt`	Adds global `OPENTELEMETRY_PROTO_API=` compile definition for otel protobuf headers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-06-19T18:40:57Z

LCOV of commit `e9454d0` during Debug Builds #149

  lines......: 82.7% (13927 of 16844 lines)
  functions..: 73.0% (1414 of 1937 functions)
  branches...: no data found

Files changed coverage rate: n/a

Full coverage report

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…ment openssl 3.6.2 -> 3.6.3 and yaml-cpp 0.8.0 -> 0.9.0. openssl stays on the 3.x line: a transitive dependency caps it at <4, so 4.0.1 conflicts in the graph. Also removes the leftover commented-out fmt/10.2.1 pin (fmt is now resolved transitively via spdlog). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…a DLL) On Windows the Conan opentelemetry-cpp/1.26.0 package builds opentelemetry_proto as a shared library (DLL + import lib), so its proto symbols are exported and consumers must reference them with __declspec(dllimport). Defining the macro empty (correct for the static libs on macOS/Linux) left the symbols unresolved on MSVC (LNK2019 on _Gauge_default_instance_, ScopeMetrics/ExportMetricsServiceRequest vftables). Use dllimport on Windows, empty elsewhere. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

nlohmann_json 3.11.3 -> 3.12.0 with force=True: opentelemetry-cpp and json-schema-validator pin an exact 3.11.3, so the override is required to resolve the graph (nlohmann_json is header-only and API-compatible). cpp-httplib 0.18.3 -> 0.27.0. This is the highest musl-safe version: starting at 0.28.0 the ConanCenter recipe unconditionally links libanl (non-blocking getaddrinfo) with no opt-out, which musl lacks and breaks the static cross-builds. 0.27.0 predates that change (needs only pthread). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

chatgpt-codex-connector Bot reviewed Jun 19, 2026

View reviewed changes

Comment thread conanfile.py Outdated

leoparente and others added 2 commits June 19, 2026 15:20

chore(deps): force npcap/1.86 override on Windows

f4dd0cc

Mirror the libpcap force=True override for the Windows npcap requirement so the pinned version wins over any transitive constraint. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

leoparente requested a review from Copilot June 19, 2026 18:33

Copilot started reviewing on behalf of leoparente June 19, 2026 18:33 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread conanfile.py Outdated

Comment thread CMakeLists.txt Outdated

leoparente and others added 3 commits June 19, 2026 15:51

chore: shorten OPENTELEMETRY_PROTO_API comment to one line

6cbb65c

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

leoparente force-pushed the chore/update-libs branch from 8140aae to a414f1c Compare June 19, 2026 22:19

leoparente force-pushed the chore/update-libs branch from a414f1c to e9454d0 Compare June 19, 2026 22:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): upgrade conan dependencies#784

chore(deps): upgrade conan dependencies#784
leoparente wants to merge 8 commits into
developfrom
chore/update-libs

leoparente commented Jun 19, 2026 •

edited

Loading

Uh oh!

leoparente commented Jun 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

leoparente commented Jun 19, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 19, 2026

Uh oh!

leoparente commented Jun 19, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

leoparente commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Upgraded

Intentionally held back (dependency-graph / platform constraints)

Build fixes required by the upgrades

Testing

Uh oh!

leoparente commented Jun 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

leoparente commented Jun 19, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 19, 2026

Uh oh!

leoparente commented Jun 19, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

LCOV of commit e9454d0 during Debug Builds #149

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

leoparente commented Jun 19, 2026 •

edited

Loading

github-actions Bot commented Jun 19, 2026 •

edited

Loading

LCOV of commit `e9454d0` during Debug Builds #149