fix(codex): polish accounts card overflow and weekly-only tray bar - #264
Merged
Conversation
Follow-up CUA proof pass on #260 caught two defects: 1. Settings Codex-accounts card: a long account email paints over the 3-button actions row at the fixed 720px window and the 'No usage data' text wraps word-by-word. Pin the info column with min-width:0 + overflow/ellipsis/nowrap, cap the title at max-width:100% so it ellipsizes, and lock the actions row with flex-shrink:0 + nowrap. 2. Tray Codex accounts menu: an account whose snapshot only carries a weekly window (primaryWindow: null) rendered no usage bar. Fall back in canonical order (primary -> secondary; the account-snapshot bridge carries no tertiary/extra windows) so weekly-only accounts still render a bar. Tests: CodexAccountsMenu renders a 42% bar from a weekly-only snapshot; CodexAccountsSection asserts the containment CSS rules are present.
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up CUA proof pass on #260 caught two polish defects found post-merge (screenshots in proof-255260/):
1. Settings accounts card email overflow — at the fixed 720px window, a long account email (e.g. an Apple private-relay alias) in
.credential-card__info strongpaints OVER the 242px-wide 3-button actions row, and the "No usage data" text wraps word-by-word. Fix (styles.css, scoped to the.codex-accounts-cardsurface used by CodexAccountsSection):.codex-accounts-card .credential-card__infogetsmin-width: 0; overflow: hidden; text-overflow: ellipsis; white-space: nowrap.codex-accounts-card .credential-card__info stronggetsmax-width: 100%+ ellipsis so the title ellipsizes and the buttons stay inside the card.codex-accounts-card .credential-card__actionsgetsflex-shrink: 0+ nowrap2. Tray accounts menu bar absent — an account whose backend returns ONLY a weekly window (snapshot
primaryWindow: null) rendered no usage bar while everything else worked.CodexAccountsMenu.tsxbar computation now prefersprimaryWindowand falls back to the next filled window in canonical order (primary → secondary; theCodexAccountUsageSnapshotbridge type carries no tertiary or extra rate windows). No existing TS fallback pattern to copy — the ambient MenuCard builds independent rows per window; the canonical ordering mirrors the Rust tray metric order intray_bridge.rs.Tests (224 → 226):
css: false, so styles.css is never applied; the test reads the stylesheet and asserts the exact containment rules instead.Verified:
tsc --noEmit,pnpm test(226 passing),pnpm run build.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.