Skip to content

Return ConditionUnknown from Unknown() #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thc1006 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return ConditionUnknown from Unknown() #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cfg/v1alpha1/condition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ func Ready() Condition {
func Unknown() Condition {
return Condition{metav1.Condition{
Type: string(ConditionTypeReady),
Status: metav1.ConditionFalse,
Status: metav1.ConditionUnknown,
LastTransitionTime: metav1.Now(),
Reason: string(ConditionReasonUnknown),
}}
Expand Down
6 changes: 6 additions & 0 deletions cfg/v1alpha1/condition_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,3 +218,9 @@ func TestConditionWithMessage(t *testing.T) {
})
}
}

func TestUnknown(t *testing.T) {
if got := Unknown().Status; got != metav1.ConditionUnknown {
t.Errorf("Unknown().Status = %q, want %q", got, metav1.ConditionUnknown)
}
}
2 changes: 1 addition & 1 deletion infra/v1alpha1/condition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ func Ready() Condition {
func Unknown() Condition {
return Condition{metav1.Condition{
Type: string(ConditionTypeReady),
Status: metav1.ConditionFalse,
Status: metav1.ConditionUnknown,
LastTransitionTime: metav1.Now(),
Reason: string(ConditionReasonUnknown),
}}
Expand Down
6 changes: 6 additions & 0 deletions infra/v1alpha1/condition_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,3 +218,9 @@ func TestConditionWithMessage(t *testing.T) {
})
}
}

func TestUnknown(t *testing.T) {
if got := Unknown().Status; got != metav1.ConditionUnknown {
t.Errorf("Unknown().Status = %q, want %q", got, metav1.ConditionUnknown)
}
}