Skip to content

Ensure parent directories are created before writing files in FolderFileSink - #55

Merged
shartte merged 2 commits into
mainfrom
fix/folder-file-sink-directory-creation
Aug 24, 2025
Merged

Ensure parent directories are created before writing files in FolderFileSink#55
shartte merged 2 commits into
mainfrom
fix/folder-file-sink-directory-creation

Conversation

@marchermans

Copy link
Copy Markdown
Member

When a folder sink is used it only creates the root directory, but not any intermediary directories of files.

An example when this crash occurs is when a Zip is used as input format, while a folder is output.

Because the zip does not have directory entries it will not trigger putDirectory properly, causing a crash when it processes the first file in a directory (generally META-INF/METADATA.MF).

@neoforged-pr-publishing

Copy link
Copy Markdown
  • Publish PR to GitHub Packages

Comment thread cli/src/main/java/net/neoforged/jst/cli/io/FolderFileSink.java Outdated
@shartte
shartte merged commit 8a68e8b into main Aug 24, 2025
2 checks passed
@shartte
shartte deleted the fix/folder-file-sink-directory-creation branch August 24, 2025 09:28
@neoforged-releases

Copy link
Copy Markdown

🚀 This PR has been released as JavaSourceTransformer version 2.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants