Skip to content

Default to execute ranked choices if applicable #11840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbudin merged 2 commits into from
Jul 21, 2026
Merged

Default to execute ranked choices if applicable #11840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86216fc
Default to execute ranked choices in ranked choice conventions
nbudin Jul 21, 2026
bcedc0a
Fix deprecation warning
nbudin Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/javascript/SignupRoundsAdmin/CreateNewSignupRoundForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { useFetcher } from 'react-router';
import { ErrorDisplay, FormGroupWithLabel } from '@neinteractiveliterature/litform';
import DateTimeInput from '../BuiltInFormControls/DateTimeInput';
import MaximumEventSignupsInput from './MaximumEventSignupsInput';
import { RankedChoiceOrder, SignupAutomationMode, SignupRoundAutomationAction } from 'graphqlTypes.generated';

type CreateNewSignupRoundFormProps = {
onCancel: () => void;
Expand Down Expand Up @@ -39,6 +40,12 @@ export default function CreateNewSignupRoundForm({ onCancel }: CreateNewSignupRo
)}
</FormGroupWithLabel>
<input type="hidden" name="start" value={start?.toISO() ?? ''} />
{convention?.signup_automation_mode === SignupAutomationMode.RankedChoice && (
<>
<input type="hidden" name="automation_action" value={SignupRoundAutomationAction.ExecuteRankedChoice} />
<input type="hidden" name="ranked_choice_order" value={RankedChoiceOrder.Asc} />
</>
)}

<FormGroupWithLabel label={t('signups.signupRounds.maximumEventSignups')}>
{(id) => (
Expand Down
2 changes: 1 addition & 1 deletion app/javascript/SignupRoundsAdmin/SignupRoundsAdminPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { apolloClientContext } from 'AppContexts';

export const loader: LoaderFunction<RouterContextProvider> = async ({ context }) => {
const client = context.get(apolloClientContext);
const { data } = await client.query<SignupRoundsAdminQueryData>({ query: SignupRoundsAdminQueryDocument });
const { data } = await client.query({ query: SignupRoundsAdminQueryDocument });
return data;
};

Expand Down
Loading