ci: fix docs preview-cleanup (HTTP 400) and move CI off Node 20#19
Merged
Conversation
…ode 20 The Docs preview cleanup workflow listed deployments with per_page=100, which the Cloudflare Pages deployments endpoint rejects with HTTP 400, so the cleanup step failed on PR close. Page through deployments with the default page size instead (env=preview&page=N until an empty page), collecting this branch's ids. Also bump actions/checkout v4->v5 and azure/setup-helm v4->v5 across the CI workflows to move off the deprecated Node 20 runtime. docs.yml is intentionally left untouched: the Astro/Starlight migration PR replaces it and already pins checkout v5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two CI fixes:
1. Fix the failing "Docs preview cleanup" workflow
The
cleanupjob listed Cloudflare Pages deployments withper_page=100, which the deployments endpoint rejects with HTTP 400 (curl -fsS-> exit 22). This is why the workflow failed on PR #16's own close event (the "Delete this branch's preview deployments" step).Fix: page through deployments with the endpoint's default page size (
?env=preview&page=N, looping until an empty page), collecting this branch's deployment ids.envwas fine; only the oversizedper_pagewas the problem. Verified the parameter contract against Cloudflare's list-deployments API docs.2. Move CI off the deprecated Node 20 runtime
Bumped
actions/checkout@v4 -> v5andazure/setup-helm@v4 -> v5acrossbuild-image,lint,release,test, andtest-integration.azure/setup-helm@v5's headline change is the node20 -> node24 runtime move with no input changes, and all usages are bare (no pinned inputs), so this is a safe bump.docs.ymlis intentionally left untouched: the Astro/Starlight migration PR (#18) replaces that workflow wholesale and already usescheckout@v5, so editing it here would collide.Testing
yaml.safe_load) and areactionlint-clean (shellcheck validated the cleanup script).