Fix xml editor - #47
Conversation
mapped tab_width with: - tabWidth (org.eclipse.ui.editors) - org.eclipse.jdt.core.formatter.tabulation.size (org.eclipse.jdt.core) - formatter_tab_size (org.eclipse.ant.ui) mapped indent_size with: - indentationSize (org.eclipse.wst.xml.core) - org.eclipse.jdt.core.formatter.indentation.size (org.eclipse.jdt.core)
ncjones
left a comment
ncjones
left a comment
There was a problem hiding this comment.
At a glance this looks fine. I'll try to do some testing today or tomorrow. Can you add a test for this scenario?
|
@ncjones how am I expected to test this? There is no test at all for the visitor, and even if there were, what could I test exactly? Sorry I'm a bit lost there :) |
|
Hi Victor,
There's a basic integration test suite using SWTBot (like Selenium but for
Eclipse):
https://github.com/ncjones/editorconfig-eclipse/blob/master/editorconfig-eclipse-functional-test/src/main/java/com/ncjones/editorconfig/eclipse/test/EditorConfigTest.java
Instructions on running the suite are in this project's Readme. Hopefully
it's simple to add a test. If not then let me know and I'll take a look.
…On Sat, Jun 16, 2018, 11:51 PM Victor Noël ***@***.***> wrote:
@ncjones <https://github.com/ncjones> how am I expected to test this?
There is no test at all for the visitor, and even if there were, what could
I test exactly? Sorry I'm a bit lost there :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABGiCKojm5fm1Tc87eso7ww7JHhvSzHuks5t9PE8gaJpZM4UhaZi>
.
|
|
@ncjones perfect, I didn't see it because I didn't get imported into eclipse with the other projects. Any reason why it's not part of the multi-module parent project? |
02b4e04 to
f9fd53f
Compare
|
@ncjones check latest commits. |
|
@ncjones ping ? :) |
|
@ncjones maybe you have more time now? ;) thanks! |
|
Can anybody merge this branch which is two years old ? |
|
@ncjones Hey, any chance we can get this merged and a new version deployed? If you're busy can we make our own version and publish it to Eclipse marketplace? Thanks :) |
5 participants
Closes #41 by setting xml editor indent size to 1 when using tabs.
This replaces #42 and I also cherry-picked the commit of #45. Si they can both be closed when this is merged.
I also used the latest version of editorconfig-core-java.