Skip to content

Implement pagination for item tags list#24

Merged
dadachi merged 1 commit intomainfrom
pagination-item-tags
Apr 3, 2026
Merged

Implement pagination for item tags list#24
dadachi merged 1 commit intomainfrom
pagination-item-tags

Conversation

@dadachi
Copy link
Copy Markdown
Contributor

@dadachi dadachi commented Apr 3, 2026

Summary

  • Add page query parameter to getItemTags() API call, propagated through repository layer
  • Implement infinite scroll pagination in ItemTagListViewModel with loadMore() that accumulates pages
  • Add scroll-near-bottom detection in ItemTagListView with loading indicator
  • ShopDetailViewModel unchanged — calls without page param to get all items (backward-compat)
  • Add 4 pagination-specific unit tests and fix TestItemTagRepository to use one-shot flows

Test plan

  • All existing unit tests pass
  • 4 new pagination tests: meta reflected in state, loadMore accumulates, no-op at last page, reload resets
  • Spotless and lint pass
  • Manual test: verify infinite scroll loads next page in item tag list screen
  • Manual test: verify shop detail screen still loads all item tags

🤖 Generated with Claude Code

Add page query parameter to getItemTags() API call, propagated through
repository layer. ItemTagListViewModel accumulates pages with loadMore()
for infinite scroll. ItemTagListView detects scroll-near-bottom to
trigger loading the next page. ShopDetailViewModel unchanged — calls
without page param for backward-compat.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@dadachi dadachi merged commit 7448b6d into main Apr 3, 2026
1 check passed
@dadachi dadachi deleted the pagination-item-tags branch April 3, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant