Implement CodedError system with NATA-XXXX error codes#23
Merged
Conversation
Add platform-specific error codes (NATA prefix) for user-facing error messages. Error types in common/errors/ package. - Add CodedError interface, AppError, NfcError, SubscriptionError - Make ApiException implement CodedError (NATA-2001, NATA-2002) - Move error types to common/errors/ package - Add Throwable.codedDescription extension - Update all ViewModels to use codedDescription - Add unit tests for all error types Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodedErrorinterface and sealed error hierarchies (AppError,NfcError,SubscriptionError) with NATA-prefixed error codes incommon/errors/packageApiExceptionfromnetwork/tocommon/errors/and make it implementCodedError(NATA-2001, NATA-2002)Throwable.codedDescriptionextension and update all ViewModels to use it for user-facing error messagesTest plan
./gradlew test— all unit tests pass (including newCodedErrorTestwith 14 test cases)[NATA-2001] ...)🤖 Generated with Claude Code