Skip to content

Fix null safety bugs and resource leak#22

Merged
dadachi merged 1 commit intomainfrom
fix_null_safety_and_resource_leak
Mar 30, 2026
Merged

Fix null safety bugs and resource leak#22
dadachi merged 1 commit intomainfrom
fix_null_safety_and_resource_leak

Conversation

@dadachi
Copy link
Copy Markdown
Contributor

@dadachi dadachi commented Mar 29, 2026

Summary

  • Fix FileOutputStream leak in shareImage() — use .use {} to guarantee stream closure on exception
  • Fix potential crash in restartApp()getLaunchIntentForPackage() can return null, replaced !! with ?: return
  • Fix 6 instances of getData()?.id!! across 2 View files — replaced with safe ?.let {} pattern

Test plan

  • ./gradlew assembleDebug passes
  • ./gradlew test passes
  • Manual: verify navigation still works from ShopSettings and ShopDetail screens

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@dadachi dadachi merged commit 8170d3d into main Mar 30, 2026
1 check passed
@dadachi dadachi deleted the fix_null_safety_and_resource_leak branch March 30, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant