Skip to content

fix: Declared mrmime as a runtime dependency (20.3.x) - #105

Merged
Aukevanoost merged 1 commit into
native-federation:20.3.xfrom
Ionaru:issues/100-v20
Aug 1, 2026
Merged

fix: Declared mrmime as a runtime dependency (20.3.x)#105
Aukevanoost merged 1 commit into
native-federation:20.3.xfrom
Ionaru:issues/100-v20

Conversation

@Ionaru

@Ionaru Ionaru commented Jul 29, 2026

Copy link
Copy Markdown

Fixes #100 for the 20.x line (same fix as #104)

packages/angular/src/builders/build/builder.ts and packages/angular/src/plugin/index.ts import mrmime at runtime, but the hand-curated dependencies list in packages/angular/package.json never included it (only the workspace root manifest did, which is why local development never noticed). The import only resolved while another installed package happened to hoist mrmime (typically the v3 mainline package left in place during migration), and ng build fails with Cannot find package 'mrmime' once that is uninstalled.

This adds mrmime to the publishable manifest's dependencies, matching the mainline package. Verified locally: nx build angular-adapter now emits packages/angular/dist/package.json with mrmime under dependencies, and the test target passes.

Note on scope: esbuild and json5 are also imported at runtime without being declared (as are @schematics/angular and @nx/devkit in the schematics and generator entry points). Those are deliberately not added here because they are highly likely to be already installed through Angular's own dependencies (@angular/build, @angular-devkit/*), unlike mrmime, which nothing else in an Angular workspace provides.

@Ionaru Ionaru changed the title fix: Declared mrmime as a runtime dependency (20.x) fix: Declared mrmime as a runtime dependency (20.3.x) Jul 29, 2026
@Aukevanoost

Copy link
Copy Markdown
Contributor

Thanks for this!

@Aukevanoost
Aukevanoost merged commit d9a8318 into native-federation:20.3.x Aug 1, 2026
1 check passed
@Ionaru
Ionaru deleted the issues/100-v20 branch August 1, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants