Add themes contribution to plugin building guides - #1027
Conversation
github-actions
Bot
added
the
documentation
|
@napari-bot make docs |
| 'plugins/_npe2_manifest.md': '# Manifest Reference\n', | ||
| 'plugins/_npe2_writers_guide.md': '(writers-contribution-guide)=\n', | ||
| 'plugins/_npe2_contributions.md': '# Contributions Reference\n(contributions-themes)=\n(contributions-commands)=\n(contributions-widgets)=\n(contributions-readers)=\n(contributions-writers)=\n(contributions-sample-data)=\n(layer-type-constraints)=\n', | ||
| 'plugins/_npe2_contributions.md': '# Contributions Reference\n\n(contributions-themes)=\n\n(contributions-commands)=\n\n(contributions-widgets)=\n\n(contributions-readers)=\n\n(contributions-writers)=\n\n(contributions-sample-data)=\n\n(layer-type-constraints)=\n', |
There was a problem hiding this comment.
Why do we need these extra \n? is this a windows thing?
|
@napari-bot make html |
|
Is this pending on next npe2? release? |
|
The fail is real, but yeah maybe it needs npe2 release? |
| plugin_docs = { | ||
| 'plugins/_npe2_sample_data_guide.md': '(sample-data-contribution-guide)=\n', | ||
| 'plugins/_npe2_readers_guide.md': '(readers-contribution-guide)=\n', | ||
| 'plugins/_npe2_themes_guide.md': '(themes-contribution-guide)=\n', |
There was a problem hiding this comment.
Something is off, there is no template for this guidein npe2 repo:
https://github.com/napari/npe2/tree/23ca363d681e1393914d86b803dd4adf091d78f2/_docs/templates
There was a problem hiding this comment.
Weird.... It builds for me locally. Maybe I accidentally have a change in my local npe2 that I forgot about
There was a problem hiding this comment.
Are you sure you're building a guide and not just a stub?
I don't see an actual guide in npe2 repo.
There was a problem hiding this comment.
I checked. This way requires npe2 contribution and release.
5 participants
References and relevant issues
Discovered while debugging napari/napari-shpinx-theme#228
Description
Adds theme contribution to guide. I think its good and ready after napari/npe2#465