Skip to content

fix: enable publishing of enscli#2157

Open
shrugs wants to merge 1 commit into
mainfrom
feat/enscli
Open

fix: enable publishing of enscli#2157
shrugs wants to merge 1 commit into
mainfrom
feat/enscli

Conversation

@shrugs
Copy link
Copy Markdown
Member

@shrugs shrugs commented May 20, 2026

makes enscli package public so changesets starts to publish it

@shrugs shrugs requested a review from a team as a code owner May 20, 2026 00:52
Copilot AI review requested due to automatic review settings May 20, 2026 00:52
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 20, 2026

⚠️ No Changeset found

Latest commit: 172a2da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
enskit-react-example.ensnode.io Ready Ready Preview, Comment May 20, 2026 12:52am
3 Skipped Deployments
Project Deployment Actions Updated (UTC)
admin.ensnode.io Skipped Skipped May 20, 2026 12:52am
ensnode.io Skipped Skipped May 20, 2026 12:52am
ensrainbow.io Skipped Skipped May 20, 2026 12:52am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0e4b92ae-e45a-49c0-85a3-d9e450ef65ad

📥 Commits

Reviewing files that changed from the base of the PR and between addfba6 and 172a2da.

📒 Files selected for processing (1)
  • packages/enscli/package.json
💤 Files with no reviewable changes (1)
  • packages/enscli/package.json

📝 Walkthrough

Walkthrough

The ENS CLI package manifest is updated to remove the "private": true field, allowing the package to be published to npm or other package registries instead of remaining private.

Changes

Package Publication Configuration

Layer / File(s) Summary
Package privacy flag removal
packages/enscli/package.json
The "private": true field is removed from the package manifest, changing the package from private to publicly distributable.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 The enscli hops out to the world today,
No longer hidden in a private way,
Now npm can share this CLI so bright,
A package set free to dance in the light! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete compared to the required template. It lacks the structured sections (Summary, Why, Testing, Notes, Pre-Review Checklist) and only provides a minimal one-line explanation. Expand the description to follow the template structure: add a Summary section, Why section with issue links if applicable, Testing section explaining how this was tested, and complete the Pre-Review Checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: enable publishing of enscli' accurately describes the main change: removing the 'private: true' field to enable package publishing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/enscli

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 20, 2026

Greptile Summary

Removes "private": true from packages/enscli/package.json so the changesets release pipeline starts publishing the enscli package to npm. The package is currently a name-reservation stub with no source files; its CHANGELOG already tracks versions from 1.10.0 to 1.14.0, meaning changesets has been bumping the version but skipping publication due to the private flag.

  • Single-line change: Removing "private": true is the only modification; all other package metadata (name, version, license, description, repository) remains unchanged.
  • Placeholder package: The directory contains only package.json, README.md, LICENSE, and CHANGELOG.md — no compiled output or bin entries — consistent with a name-reservation publish intended to claim the enscli name on npm.

Confidence Score: 5/5

Safe to merge — a one-line removal that simply unblocks the existing changesets publish pipeline for a name-reservation package.

The only change is removing a single flag from a stub package that has no source code, no binaries, and no runtime consumers. The CHANGELOG history confirms the version has been tracking correctly all along; publishing at 1.14.0 is the expected next step.

No files require special attention.

Important Files Changed

Filename Overview
packages/enscli/package.json Removes "private": true to allow changesets to publish this name-reservation placeholder package to npm.

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant CS as Changesets CI
    participant NPM as npm Registry

    Dev->>CS: Merge PR (private: true removed)
    CS->>CS: Detect enscli in publishable packages
    CS->>NPM: "Publish enscli@1.14.0"
    NPM-->>CS: Published successfully
    CS-->>Dev: Release created
Loading

Reviews (1): Last reviewed commit: "fix: enable publishing of enscli" | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables publishing for the enscli package by removing its private flag so Changesets will include it in npm publishing.

Changes:

  • Removed "private": true from packages/enscli/package.json to allow publishing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

{
"private": true,
"name": "enscli",
"version": "1.14.0",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants