fix(docs): correct nested list rendering in docs site#2098
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR reformats contributor and terminology MDX content for consistent markdown list and section rendering, and consolidates Starlight CSS list rules (.sl-markdown-content) to standardize list color, spacing, and indentation across the docs site. ChangesContributor docs & list styling
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes nested list rendering issues on the ENSNode docs site by adjusting Starlight markdown list styling, and updates the PR-process documentation formatting to render nested lists as intended.
Changes:
- Update
.sl-markdown-contentlist CSS to use consistent margins/indentation forul/ol. - Tweak
prs.mdxmarkdown formatting/indentation so nested lists render correctly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/ensnode.io/src/styles/starlight.css | Adjusts list spacing/indent rules for markdown content to improve nested list rendering. |
| docs/ensnode.io/src/content/docs/docs/reference/contributing/prs.mdx | Fixes markdown nesting/italics formatting so lists render properly in the docs site. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ndent Agent-Logs-Url: https://github.com/namehash/ensnode/sessions/2e1ca611-f520-4b00-8fbd-644d40aa6b7f Co-authored-by: notrab <950181+notrab@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional Suggestions:
- CSS rule uses physical property
margin-topwhile parent selector uses logical properties, breaking RTL language support
- Nested list rule uses physical
margin-topproperty while parent list uses logical properties, breaking RTL language support
Greptile SummaryThis PR fixes broken nested list rendering on the ENSNode docs site by correcting the root CSS cause (
Confidence Score: 5/5Docs-only change touching CSS and MDX files; no runtime logic affected. All four changed files are documentation assets (CSS + MDX). The CSS fix correctly replaces the problematic list-style-position: inside rule with standard padding-inline-start and updates nested-list selectors. MDX edits are mechanical reformatting. No application logic, APIs, or data are touched. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[MDX source files<br/>prs.mdx / terminology.mdx<br/>database-schemas.mdx] -->|Markdown list syntax<br/>blank lines + dash markers<br/>3-space sub-item indent| B[Starlight MDX parser]
B -->|Generates HTML<br/>ul / ol / li elements| C[Rendered HTML]
D[starlight.css] -->|list-style: disc / decimal<br/>padding-inline-start: 40px<br/>nested: padding-inline-start: 1.5em| C
C --> E[Correct nested list<br/>rendering in browser]
style A fill:#e8f4f8
style D fill:#e8f4f8
style E fill:#d4edda
Reviews (2): Last reviewed commit: "Merge branch 'main' into fix/docs-list-i..." | Re-trigger Greptile |
| | `root_registry_owner_id` | `text` | yes | ENSv1 only: the owner recorded in the root ENSv1 registry. `null` for ENSv2 domains. | | ||
| | `canonical` | `boolean` | no | Whether this Domain is part of the canonical nametree. This encodes bi-directional agreement between `domains.subregistry_id` and `registries.canonical_domain_id`, so traversal of the canonical nametree filtered to domains/registries where `canonical=true` is safe and doesn't require edge-authenticating oneself (i.e. don't need to compare `domains.subregistry_id` and `registries.canonical_domain_id` in the query, can just `WHERE canonical = true`). Mirrors the parent Registry's flag. Default `false`. | | ||
| :::note | ||
| Domain-Resolver relations are tracked via the Protocol Acceleration plugin, not stored on the domain row. The parent domain is derived via `registry_canonical_domains`, not stored on the domain row. |
There was a problem hiding this comment.
I defer to what was on the main branch in terms of the actual content
Lite PR
Tip: Review docs on the ENSNode PR process
Summary
Why
Testing
Notes for Reviewer (Optional)
Pre-Review Checklist (Blocking)