Conversation
- lines 581-584: shifted wrong direction - line 685: wrong intendation - lines 214, 403, 410: confusing function name modified: max30102/__init__.py
modified: README.md
1 renamed set_pulse_amplitude_it() to set_pulse_amplitude_ir() 2 changed bit shift direction in fifo_bytes_to_int() to return (value[0] & 0x3FFFF) >> (3 - self._pulse_width) 3 changed in check() the intendation to left for return True to let the function handle all samples in buffer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases v0.5.0. Bundles the bug fixes from #26 plus example/changelog updates.
Breaking changes
set_pulse_amplitude_it()renamed toset_pulse_amplitude_ir(). No back-compat alias.fifo_bytes_to_int()shift direction fixed. Raw sample magnitudes will change wheneverpulse_width != 0; downstream calibration may need re-tuning.Other changes
check()now drains the full sensor FIFO per call (was returning after the first sample). Examples updated to usewhile sensor.available()instead ofif sensor.available().package.json,setup.py, and changelog.Credits
Thanks to @sakluk (#26) for the original fixes.