Fewer ByteString allocations in CPS parser with ByteStringIdx - #46
Draft
mzabani wants to merge 7 commits into
Draft
Fewer ByteString allocations in CPS parser with ByteStringIdx#46mzabani wants to merge 7 commits into
ByteStringIdx#46mzabani wants to merge 7 commits into
Conversation
It's only used to fetch field values, and values with length exactly 0 are extremely rare
mzabani
changed the title
ByteStringIdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of performance optimizations
TODO:
unsafeDecodeWorda safe function by taking a GADT that specifies the Word type/size0as the only argument. We want them to be inlined.