Allow hiding the toolbar for kiosk displays - #28
Closed
jbeers wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks for the PR, and sorry to turn it down, I don't want a third setting on the toolbar. toolbar_position and toolbar_autohide both go meaningless once the bar is off, and the configurable toolbar gives "no toolbar" for free as "every element at order 0", so this would be a second mechanism for the same thing. And there is problem on touch: with the bar hidden on a touch-only device there's no way back out - no menu, no settings, recovery only by editing config.toml in app-private storage. For fullscreen, I'm leaning toward making it a toggleable mode rather than a settings flag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
display.toolbar_visiblesetting for kiosk/thin-client use cases. When disabled, the web viewport uses the full display while controller shortcuts and Settings remain available.Includes a config parsing test and documentation.