ci: drop build inputs mbt no longer declares - #10
Merged
Conversation
Every pull_request run fails at startup ("This run likely failed because
of a workflow file issue") without executing a single step. The caller
passes `incremental` and `base_sha` to mvslovers/mbt's reusable
build.yml, which since the v2 host-build migration declares only
`cc370_ref`. Passing undefined inputs to a reusable workflow is a
startup failure, not a build error, so nothing in the log points at the
project.
This file has been unchanged since the v1-era mbt migration; lua370's
own move to mbt v2 updated project.toml and the Makefile but not the
workflow caller. ufsd, ftpd, httpd and mvsmf all call the same reusable
workflow with no `with:` block -- this brings lua370 in line.
The trigger stays pull_request-only, unchanged.
mgrossmann
added a commit
that referenced
this pull request
Aug 7, 2026
Until now Build only ran on pull_request, so nothing verified main after a merge and a direct push to main was never built at all. That is how the reusable-workflow input mismatch fixed in #10 stayed hidden from 2026-03-10 until the next PR opened. This matches ufsd, ftpd, httpd and mvsmf, which all build on both pull_request and push to main; the file is now identical to theirs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
pull_requestrun currently fails at startup without executing a step — GitHub reports only "This run likely failed because of a workflow file issue", which points nowhere near the project. Most recently on #9 (run 31199878426, failed in 1s).Cause
The caller passes two inputs the reusable workflow no longer declares:
mvslovers/mbt'sbuild.ymlonmaindeclares onlycc370_ref. Passing undefined inputs to a reusable workflow is a startup failure, so no job is created and no log explains it.This file has been unchanged since the v1-era mbt migration. lua370's own move to mbt v2 (50a657f) updated
project.tomland theMakefilebut not the workflow caller, andbuild.ymlonly triggers onpull_request— so the breakage sat dormant until the next PR. Last green Build run was 2026-03-10.Fix
Delete the
with:block.ufsd,ftpd,httpdandmvsmfall call the same reusable workflow with no inputs; this brings lua370 in line.The
pull_request-only trigger is left as-is — the siblings also build onpush: [main], but changing when this project builds is a separate decision.release.ymlis unaffected: it is a correct thin caller with nowith:block.Note
This PR is its own test — if the Build check runs at all, the startup failure is fixed.