Open
Conversation
petrvanekrobe
force-pushed
the
attributes_listing_and_wheels_usage
branch
from
a979e6b to
4583f7e
Compare
Contributor
Author
|
Define/describe new XML attributes for Attribute, (table 9). |
Contributor
Author
|
I have updated the Attribute description, updated the Annex A and Annex B, see individual commits. |
danielmuellerma
requested changes
Apr 23, 2026
| | ActivationGroup | [Node](#user-content-attrtype-node ) | Optional link to the activation group. The starting point is the [activation groups](#user-content-activation-groups ) node. | | ||
| | Feature | [Node](#user-content-attrtype-node ) | Link to the corresponding feature. The starting point is the [feature groups](#user-content-feature-groups ) node. | | ||
| | MainAttribute | [Node](#user-content-attrtype-node ) | Optional link to the main attribute. The starting point is the [attribute](#user-content-attribute ) node. | | ||
| | PhysicalUnit | [Enum](#user-content-attrtype-enum ) | The currently defined unit values are: “None”, “Percent”, “Length” (m), “Mass” (kg), “Time” (s), “Temperature” (K), “LuminousIntensity”(cd), “Angle” (degree), “Force” (N), “Frequency” (Hz), “Current” (A), “Voltage” (V), “Power” (W), “Energy” (J), “Area” (m2), “Volume” (m3), “Speed” (m/s), “Acceleration” (m/s2), “AngularSpeed” (degree/s), “AngularAccc” (degree/s2), “WaveLength” (nm), “ColorComponent”. Default: “None”. | | ||
| | Color | [ColorCIE](#user-content-attrtype-colorcie ) | Optional. Defines the color for the attribute. | | ||
| | | | | | ||
|
|
||
| | Definition | [String](#user-content-attrtype-string ) | Description of what the attribute defines. | |
Contributor
There was a problem hiding this comment.
I think Definition and Explanation should be optional
| | | | | | ||
|
|
||
| | Definition | [String](#user-content-attrtype-string ) | Description of what the attribute defines. | | ||
| | Explanation | [String](#user-content-attrtype-string ) | Longer form explanation of what the attribute defines with focus on the user. | |
Contributor
There was a problem hiding this comment.
The other ones should have a default = false
| | WhiteCount | Controls if White LED is proportionally added to RGB. | | ||
| | StrobeMode | Changes strobe style - strobe, pulse, random strobe, etc. - of the shutter attribute. | | ||
| | ZoomMode | Changes modes of the fixture´s zoom. | | ||
| | FocusMode | Changes modes of the fixture’s focus - manual or auto- focus. | | ||
| | IrisMode | Changes modes of the fixture’s iris - linear, strobe, pulse. | | ||
| | Fan(n)Mode | Controls fan (n) mode. | | ||
| | FanMode | Controls fan (n) mode. | |
Contributor
There was a problem hiding this comment.
we should remove the (n) from the description, too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is merging the
gdtf_attributes_with_description.jsonwith the GDTF Attributes listingattributes_listing.xmlAnnex B (normative) Attribute Listing. This is to resolve #299 .Further requirements:
"UseEmmiter": "False", "UseFilter": "False", "UseWheel": "False", "UseWheelSlot": "False", "UseGamut": "False", "UseColorSpace": "False",Helper python script is still included, but can be removed later. Right now, it could be modified and re-run to change the default values / can also be done by find-replace...