fix: decode negative xsd:duration as seconds, not days#1493
Open
Noethix55555 wants to merge 1 commit into
Open
fix: decode negative xsd:duration as seconds, not days#1493Noethix55555 wants to merge 1 commit into
Noethix55555 wants to merge 1 commit into
Conversation
The PT- workaround passed total_seconds() into timedelta's positional days argument, so PT-30S decoded as -30 days instead of -30 seconds (off by 86400). Pass it as seconds=.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Duration.pythonvaluedecoded negativexsd:durationvalues with the wrong unit. ThePT-workaround passedresult.total_seconds()intotimedelta's positionaldaysargument, soPT-30Sdecoded as -30 days instead of -30 seconds (off by 86400). This passes the value asseconds=.Added a regression test in
tests/test_xsd_builtins.py(TestDuration.test_pythonvalue_negative). Full suite passes (473 passed, 17 pre-existing network skips).Closes #1492.