Make strings translatable

[Jojo-Schmitz]

Resolves: #110

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 16c4a716-9959-4dd2-9018-4dcf6aa9295d

📥 Commits

Reviewing files that changed from the base of the PR and between 8c223d8 and 925c23c.

📒 Files selected for processing (1)

• framework/global/serialization/xmlstreamreader.cpp

---

📝 Walkthrough

Walkthrough

In xmlstreamreader.cpp, the translation.h header is added and two hard-coded Unicode error string literals in setData()—one for empty documents and one for unknown encodings—are replaced with calls to mtrc(...) to produce localized, translatable error messages. No public interfaces or control flow are changed.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only references the issue and omits the required summary and checklist details.	Add a short change summary and fill out the repository checklist items required by the template.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: making strings translatable.
Linked Issues check	✅ Passed	The change makes the two reported texts translatable and capitalized, matching issue #110.
Out of Scope Changes check	✅ Passed	The PR only touches the xmlstreamreader error strings needed for issue #110.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}