fix(ci): make govulncheck failures actionable - #583
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
- Upgrade Go to 1.26.6 across modules and builder images - Upgrade pgx to 5.9.2 to resolve the observer vulnerability Signed-off-by: Verónica López <veronica.lopez@supabase.io>
- Pin govulncheck and distinguish reachable findings from analysis failures. - Upload only valid SARIF and remove the duplicate scan. Signed-off-by: Verónica López <veronica.lopez@supabase.io>
Verolop
force-pushed
the
fix/govulncheck-workflow
branch
from
August 18, 2026 05:07
a9b998e to
758d9de
Compare
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
niconosenzo
reviewed
Aug 18, 2026
Comment on lines
+49
to
+56
| if jq -e ' | ||
| [.runs[].results[]? | select(.level == "error")] | | ||
| length > 0 | ||
| ' govulncheck.sarif > /dev/null; then | ||
| result=vulnerabilities | ||
| elif [[ "$status" -eq 0 ]]; then | ||
| result=clean | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this PR makes the
govulncheckworkflow report actionable failures instead of masking scanner and package-loading errors as vulnerabilities or invalid SARIF uploads.The previous version of this workflow uploaded SARIF unconditionally and treated every nonzero scanner exit as “vulnerabilities found.” A compilation or package-loading failure could therefore produce an empty or malformed SARIF file, fail during upload with an unrelated JSON error, and then rerun the complete scan.
Main changes
govulnchecktov1.7.0instead of installinglatest.Testing
Exercised the pinned scanner locally against both an analysis failure, which produced no usable SARIF, and a completed scan with valid SARIF findings.
Depends on #584
Closes #579