Skip to content

W-23599683: Stop double-zipping single-file upload artifacts #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlischetti merged 1 commit into from
Jul 28, 2026
Merged

W-23599683: Stop double-zipping single-file upload artifacts #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,28 +73,49 @@ jobs:

# Upload the artifact file
- name: Upload generated script
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: dw-${{env.NATIVE_VERSION}}-${{runner.os}}
# archive:false skips the redundant outer zip (the distro is already a
# .zip) and names the artifact after the file — which already carries
# ${matrix.script_name}, so the matrix legs don't collide. No `name:`:
# it would be ignored under archive:false.
path: native-cli/build/distributions/native-cli-${{env.NATIVE_VERSION}}-native-distro-${{ matrix.script_name }}.zip
archive: false

# Upload the Python wheel
- name: Upload Python wheel
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: dw-python-wheel-${{env.NATIVE_VERSION}}-${{runner.os}}
# archive:false skips the redundant outer zip and names the artifact
# after the wheel — whose platform tag (manylinux/win_amd64/…) is
# already OS-unique, so the matrix legs don't collide. No `name:`: it
# would be ignored under archive:false.
path: native-lib/python/dist/dataweave_native-0.0.1-py3-*.whl
archive: false

# npm pack emits the same filename (dataweave-native-0.0.1.tgz) on every
# OS. With archive:false the file NAME becomes the artifact name (the
# `name:` input is ignored), so copy to an OS-qualified name first to keep
# the matrix legs from colliding.
- name: Stage OS-qualified Node package
run: cp native-lib/node/dataweave-native-0.0.1.tgz "native-lib/node/dataweave-native-0.0.1-${{ runner.os }}.tgz"
shell: bash

# Upload the Node.js package
- name: Upload Node package
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: dw-node-package-${{env.NATIVE_VERSION}}-${{runner.os}}
path: native-lib/node/dataweave-native-0.0.1.tgz
path: native-lib/node/dataweave-native-0.0.1-${{ runner.os }}.tgz
# Single .tgz (already gzip-compressed); skip the redundant outer zip
# (v7+ feature). archive:false ignores `name:` and uses the file name,
# which the copy above made OS-unique.
archive: false

# Upload the native shared library + header together per OS
# Upload the native shared library + header together per OS. Multiple
# files, so this stays archived (archive:false allows only one file); the
# zip is wanted here and `name:` still applies.
- name: Upload native shared library
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: dwlib-${{env.NATIVE_VERSION}}-${{runner.os}}
path: |
Expand Down
41 changes: 31 additions & 10 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,28 +110,49 @@ jobs:

# Upload the artifact file
- name: Upload generated script
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: dw-${{env.NATIVE_VERSION}}-${{runner.os}}
# archive:false skips the redundant outer zip (the distro is already a
# .zip) and names the artifact after the file — which already carries
# ${matrix.script_name}, so the matrix legs don't collide. No `name:`:
# it would be ignored under archive:false.
path: native-cli/build/distributions/native-cli-${{env.NATIVE_VERSION}}-native-distro-${{ matrix.script_name }}.zip
archive: false

# Upload the Python wheel
- name: Upload Python wheel
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: dw-python-wheel-${{env.NATIVE_VERSION}}-${{runner.os}}
# archive:false skips the redundant outer zip and names the artifact
# after the wheel — whose platform tag (manylinux/win_amd64/…) is
# already OS-unique, so the matrix legs don't collide. No `name:`: it
# would be ignored under archive:false.
path: native-lib/python/dist/dataweave_native-0.0.1-py3-*.whl
archive: false

# npm pack emits the same filename (dataweave-native-0.0.1.tgz) on every
# OS. With archive:false the file NAME becomes the artifact name (the
# `name:` input is ignored), so copy to an OS-qualified name first to keep
# the matrix legs from colliding.
- name: Stage OS-qualified Node package
run: cp native-lib/node/dataweave-native-0.0.1.tgz "native-lib/node/dataweave-native-0.0.1-${{ runner.os }}.tgz"
shell: bash

# Upload the Node.js package
- name: Upload Node package
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: dw-node-package-${{env.NATIVE_VERSION}}-${{runner.os}}
path: native-lib/node/dataweave-native-0.0.1.tgz

# Upload the native shared library + header together per OS
path: native-lib/node/dataweave-native-0.0.1-${{ runner.os }}.tgz
# Single .tgz (already gzip-compressed); skip the redundant outer zip
# (v7+ feature). archive:false ignores `name:` and uses the file name,
# which the copy above made OS-unique.
archive: false

# Upload the native shared library + header together per OS. Multiple
# files, so this stays archived (archive:false allows only one file); the
# zip is wanted here and `name:` still applies.
- name: Upload native shared library
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: dwlib-${{env.NATIVE_VERSION}}-${{runner.os}}
path: |
Expand Down
Loading