Skip to content

[all components] Export CssVars and DataAttributes#5243

Open
superhooman wants to merge 2 commits into
mui:masterfrom
superhooman:feature/public-css-vars-data-attributes
Open

[all components] Export CssVars and DataAttributes#5243
superhooman wants to merge 2 commits into
mui:masterfrom
superhooman:feature/public-css-vars-data-attributes

Conversation

@superhooman

Copy link
Copy Markdown

Related to #5242

34 components now export their CssVars/DataAttributes enums publicly

@pkg-pr-new

pkg-pr-new Bot commented Jul 15, 2026

Copy link
Copy Markdown

commit: f25fa28

@code-infra-dashboard

code-infra-dashboard Bot commented Jul 15, 2026

Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@base-ui/react 🔺+35.2KB(+7.81%) 🔺+5.16KB(+3.53%)

Details of bundle changes

Performance

Total duration: 1,295.14 ms -61.03 ms(-4.5%) | Renders: 78 (+0) | Paint: 2,029.67 ms -72.10 ms(-3.4%)

Test Duration Renders
Popover mount (300 instances) 59.13 ms ▼-15.01 ms(-20.2%) 1 (+0)

13 tests within noise — details


Check out the code infra dashboard for more information about this PR.

@netlify

netlify Bot commented Jul 15, 2026

Copy link
Copy Markdown

Deploy Preview for base-ui ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f25fa28
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a57a505b574bd0008385866
😎 Deploy Preview https://deploy-preview-5243--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@superhooman

superhooman commented Jul 15, 2026

Copy link
Copy Markdown
Author

So, I tried to just straight up exporting these enums as is

But I have a questions:

  • Are we okay with no reexports from derived components like AlertDialog (Dialog) and Autocomplete (Combobox)? Since they use the same enums as underlying components
  • Should I place these exports in a separate barrel file? So it looks cleaner in the main one
  • Is it even worth it given it increases bundle size? Perhaps we can publish it as a separate package?

@superhooman superhooman force-pushed the feature/public-css-vars-data-attributes branch from 94efb19 to f25fa28 Compare July 15, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant