Skip to content

Formspec cleanup and improvements#209

Open
OgelGames wants to merge 5 commits into
masterfrom
formspec_cleanup
Open

Formspec cleanup and improvements#209
OgelGames wants to merge 5 commits into
masterfrom
formspec_cleanup

Conversation

@OgelGames

@OgelGames OgelGames commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

This is mostly a code cleanup PR, but with a few formspec changes and improvements.

  • Moved fs_helpers to a separate file, cleaned-up existing code, and added several new helper functions
  • Cleaned-up formspec code using the new helper functions.
  • Standardized all formspecs and reduced the amount of text buttons.
  • Improved i3 and mcl_formspec compatibility with correct styling.
  • Replaced solid color images in sorting tube formspecs with boxes.

The stack-wise injector is the best example of the visual changes, since it includes one of every element. Top row is before, bottom row is after:

formspecs

Fixes #205, closes #208

@OgelGames OgelGames added enhancement New feature or request compatibility Compatibility with games or other mods cleanup code and other cleanups labels Jul 2, 2026
@OgelGames OgelGames mentioned this pull request Jul 2, 2026
4 tasks
@wsor4035

wsor4035 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

we really should make these dynamic instead of hardcoded meta

@The4codeblocks

This comment was marked as spam.

@The4codeblocks

Copy link
Copy Markdown
Contributor

we really should make these dynamic instead of hardcoded meta

explain?

@wsor4035

wsor4035 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

we really should make these dynamic instead of hardcoded meta

explain?

core.show_formspec instead of encoding it in meta

@The4codeblocks

Copy link
Copy Markdown
Contributor

we really should make these dynamic instead of hardcoded meta

explain?

core.show_formspec instead of encoding it in meta

well that's with the compromise of not having the forms autoupdate

@OgelGames

Copy link
Copy Markdown
Contributor Author

I still don't like the idea of any node formspec being dynamic unless it needs to be.

Good examples are fancyvend and travelnet, because in both cases the formspecs need to be different depending on who looks at it.

For pipeworks nodes, which only need to update if you change a setting, should not be dynamic in my opinion.

@The4codeblocks

This comment was marked as off-topic.

@OgelGames

This comment was marked as off-topic.

@The4codeblocks

This comment was marked as off-topic.

@SwissalpS

This comment was marked as off-topic.

@The4codeblocks

This comment was marked as off-topic.

@OgelGames

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup code and other cleanups compatibility Compatibility with games or other mods enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use real coordinates in all formspecs

4 participants