stream_curl: add support for Icecast metadata#17907
Open
kasper93 wants to merge 6 commits into
Open
Conversation
Member
Author
|
This is extracting the metadata in similar way to http.c in lavf. However, I'm not certain if the in-line metadata, shouldn't be handled by the demuxer itself, to updated them as they are playing in current time, not as they arrive at transport level. Though, it was like that in lavf forever. Just for context, there are two kinds of information, in http header response, that mostly describe the stream and in data payload, interleaved with audio stream. Currently both are handled at transport level, but I doubt it's correct... |
This is independent of other CA certificate locations set at run time or build time. Those locations are searched in addition to the native CA store.
We shouldn't default to no verification in current year. User can opt-out if needed. Keep it disable for builds without libcurl when libavformat is older than 63.0.100. This is done to match ffmpeg's timeline for enabling tls_verify by default in lavf, also to ensure we the default verify locations will be loaded on such version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.