Skip to content

Please consider the following formatting changes to #15456 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 2 commits into from
Closed

Please consider the following formatting changes to #15456 #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9012bd5
ITS: integrate track extension in road finding
mpuccio May 20, 2026
30202c8
Please consider the following formatting changes
alibuild May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Detectors/ITSMFT/ITS/tracking/GPU/ITStrackingGPU/TrackerTraitsGPU.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ class TrackerTraitsGPU final : public TrackerTraits<NLayers>
void computeLayerCells(const int iteration) final;
void findCellsNeighbours(const int iteration) final;
void findRoads(const int iteration) final;
void extendTracks(const int iteration) final;

void setBz(float) final;

Expand All @@ -48,11 +47,6 @@ class TrackerTraitsGPU final : public TrackerTraits<NLayers>
int getTFNumberOfCells() const override;

private:
bool hasTrackFollower(const int iteration) const;

void buildTrackExtensionCandidates(const int iteration, typename TrackerTraits<NLayers>::TrackExtensionCandidates& candidatesPerTrack) final;
bool materializeTrackExtensionCandidate(TrackITSExt& track, const typename TrackerTraits<NLayers>::TrackExtensionCandidateN& candidate, const int iteration) final;

IndexTableUtilsN* mDeviceIndexTableUtils;
gpu::TimeFrameGPU<NLayers>* mTimeFrameGPU;
};
Expand Down
18 changes: 16 additions & 2 deletions Detectors/ITSMFT/ITS/tracking/GPU/ITStrackingGPU/TrackingKernels.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,6 @@ void countTrackSeedHandler(TrackSeed<NLayers>* trackSeeds,
const std::vector<float>& layerxX0Host,
const unsigned int nSeeds,
const float Bz,
const int startLevel,
const float maxChi2ClusterAttachment,
const float maxChi2NDF,
const int reseedIfShorter,
Expand All @@ -276,20 +275,35 @@ template <int NLayers>
void computeTrackSeedHandler(TrackSeed<NLayers>* trackSeeds,
const TrackingFrameInfo** foundTrackingFrameInfo,
const Cluster** unsortedClusters,
const IndexTableUtils<NLayers>* utils,
const typename ROFMaskTable<NLayers>::View& rofMask,
const typename ROFOverlapTable<NLayers>::View& rofOverlaps,
const Cluster** clusters,
const unsigned char** usedClusters,
const int** clustersIndexTables,
const int** ROFClusters,
o2::its::TrackITSExt* tracks,
const int* seedLUT,
TrackExtensionHypothesis<NLayers>* activeHypotheses,
TrackExtensionHypothesis<NLayers>* nextHypotheses,
const std::vector<float>& layerRadiiHost,
const std::vector<float>& minPtsHost,
const std::vector<float>& layerxX0Host,
const unsigned int nSeeds,
const unsigned int nTracks,
const float Bz,
const int startLevel,
const float maxChi2ClusterAttachment,
const float maxChi2NDF,
const int reseedIfShorter,
const bool repeatRefitOut,
const bool shiftRefToCluster,
const int nLayers,
const int phiBins,
const int beamWidth,
const bool extendTop,
const bool extendBot,
const float nSigmaCutPhi,
const float nSigmaCutZ,
const o2::base::Propagator* propagator,
const o2::base::PropagatorF::MatCorrType matCorrType,
o2::its::ExternalAllocator* alloc);
Expand Down
154 changes: 30 additions & 124 deletions Detectors/ITSMFT/ITS/tracking/GPU/cuda/TrackerTraitsGPU.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,10 +304,13 @@ template <int NLayers>
void TrackerTraitsGPU<NLayers>::findRoads(const int iteration)
{
bounded_vector<bounded_vector<int>> firstClusters(this->mTrkParams[iteration].NLayers, bounded_vector<int>(this->getMemoryPool().get()), this->getMemoryPool().get());
bounded_vector<bounded_vector<int>> sharedFirstClusters(this->mTrkParams[iteration].NLayers, bounded_vector<int>(this->getMemoryPool().get()), this->getMemoryPool().get());
firstClusters.resize(this->mTrkParams[iteration].NLayers);
sharedFirstClusters.resize(this->mTrkParams[iteration].NLayers);
const auto hostTopology = mTimeFrameGPU->getTrackingTopologyView();
const bool extendTop = this->mTrkParams[iteration].PassFlags[IterationStep::TrackFollowerTop];
const bool extendBot = this->mTrkParams[iteration].PassFlags[IterationStep::TrackFollowerBot];
const bool extendTracks = extendTop || extendBot;
size_t nExtendedTracks{0};
size_t nExtendedClusters{0};
for (int startLevel{this->mTrkParams[iteration].CellsPerRoad()}; startLevel >= this->mTrkParams[iteration].CellMinimumLevel(); --startLevel) {
bounded_vector<TrackSeed<NLayers>> trackSeeds(this->getMemoryPool().get());
for (int startCellTopologyId{0}; startCellTopologyId < hostTopology.nCells; ++startCellTopologyId) {
Expand Down Expand Up @@ -356,7 +359,6 @@ void TrackerTraitsGPU<NLayers>::findRoads(const int iteration)
this->mTrkParams[iteration].LayerxX0,
trackSeeds.size(),
this->mBz,
startLevel,
this->mTrkParams[iteration].MaxChi2ClusterAttachment,
this->mTrkParams[iteration].MaxChi2NDF,
this->mTrkParams[iteration].ReseedIfShorter,
Expand All @@ -366,153 +368,57 @@ void TrackerTraitsGPU<NLayers>::findRoads(const int iteration)
this->mTrkParams[iteration].CorrType,
mTimeFrameGPU->getFrameworkAllocator());
mTimeFrameGPU->createTrackITSExtDevice(trackSeeds.size());
if (extendTracks) {
mTimeFrameGPU->createTrackExtensionScratchDevice(kTrackExtensionLaunchThreads, this->mTrkParams[iteration].TrackFollowerBeamWidth);
}
computeTrackSeedHandler(mTimeFrameGPU->getDeviceTrackSeeds(),
mTimeFrameGPU->getDeviceArrayTrackingFrameInfo(),
mTimeFrameGPU->getDeviceArrayUnsortedClusters(),
mTimeFrameGPU->getDeviceIndexTableUtils(),
mTimeFrameGPU->getDeviceROFMaskTableView(),
mTimeFrameGPU->getDeviceROFOverlapTableView(),
mTimeFrameGPU->getDeviceArrayClusters(),
(const unsigned char**)mTimeFrameGPU->getDeviceArrayUsedClusters(),
mTimeFrameGPU->getDeviceArrayClustersIndexTables(),
mTimeFrameGPU->getDeviceROFrameClusters(),
mTimeFrameGPU->getDeviceTrackITSExt(),
mTimeFrameGPU->getDeviceTrackSeedsLUT(),
extendTracks ? mTimeFrameGPU->getDeviceActiveTrackExtensionHypotheses() : nullptr,
extendTracks ? mTimeFrameGPU->getDeviceNextTrackExtensionHypotheses() : nullptr,
this->mTrkParams[iteration].LayerRadii,
this->mTrkParams[iteration].MinPt,
this->mTrkParams[iteration].LayerxX0,
trackSeeds.size(),
mTimeFrameGPU->getNTrackSeeds(),
this->mBz,
startLevel,
this->mTrkParams[iteration].MaxChi2ClusterAttachment,
this->mTrkParams[iteration].MaxChi2NDF,
this->mTrkParams[iteration].ReseedIfShorter,
this->mTrkParams[iteration].RepeatRefitOut,
this->mTrkParams[iteration].ShiftRefToCluster,
this->mTrkParams[iteration].NLayers,
this->mTrkParams[iteration].PhiBins,
this->mTrkParams[iteration].TrackFollowerBeamWidth,
extendTop,
extendBot,
this->mTrkParams[iteration].TrackFollowerNSigmaCutPhi,
this->mTrkParams[iteration].TrackFollowerNSigmaCutZ,
mTimeFrameGPU->getDevicePropagator(),
this->mTrkParams[iteration].CorrType,
mTimeFrameGPU->getFrameworkAllocator());
mTimeFrameGPU->downloadTrackITSExtDevice();

auto& tracks = mTimeFrameGPU->getTrackITSExt();
this->acceptTracks(iteration, tracks, firstClusters);
this->acceptTracks(iteration, tracks, firstClusters, nExtendedTracks, nExtendedClusters);
mTimeFrameGPU->loadUsedClustersDevice();
}
this->markTracks(iteration);
if (!hasTrackFollower(iteration)) {
// wipe the artefact memory
mTimeFrameGPU->popMemoryStack(iteration);
if (extendTracks) {
LOGP(info, "Integrated track extension accepted {} tracks using {} clusters in iteration {}", nExtendedTracks, nExtendedClusters, iteration);
}
};

template <int NLayers>
void TrackerTraitsGPU<NLayers>::extendTracks(const int iteration)
{
TrackerTraits<NLayers>::extendTracks(iteration);
mTimeFrameGPU->loadUsedClustersDevice();
// wipe the artefact memory kept alive for the track follower
this->markTracks(iteration);
// wipe the artefact memory
mTimeFrameGPU->popMemoryStack(iteration);
}

template <int NLayers>
bool TrackerTraitsGPU<NLayers>::hasTrackFollower(const int iteration) const
{
return this->mTrkParams[iteration].PassFlags[IterationStep::TrackFollowerTop] ||
this->mTrkParams[iteration].PassFlags[IterationStep::TrackFollowerBot];
}

template <int NLayers>
void TrackerTraitsGPU<NLayers>::buildTrackExtensionCandidates(const int iteration, typename TrackerTraits<NLayers>::TrackExtensionCandidates& candidatesPerTrack)
{
const auto nTracks = this->mTimeFrame->getTracks().size();
const int beamWidth = std::max(1, this->mTrkParams[iteration].TrackFollowerBeamWidth);
mTimeFrameGPU->syncStreams();
mTimeFrameGPU->loadTrackExtensionStartTracksDevice();
mTimeFrameGPU->createTrackExtensionCandidatesDevice(nTracks);
mTimeFrameGPU->createTrackExtensionScratchDevice(kTrackExtensionLaunchThreads, beamWidth);
std::array<float, NLayers> layerRadii{};
std::array<float, NLayers> layerxX0{};
for (int iLayer{0}; iLayer < this->mTrkParams[iteration].NLayers; ++iLayer) {
layerRadii[iLayer] = this->mTrkParams[iteration].LayerRadii[iLayer];
layerxX0[iLayer] = this->mTrkParams[iteration].LayerxX0[iLayer];
}
computeTrackExtensionCandidatesHandler<NLayers>(mTimeFrameGPU->getDeviceTrackExtensionStartTracks(),
mTimeFrameGPU->getDeviceIndexTableUtils(),
mTimeFrameGPU->getDeviceROFMaskTableView(),
mTimeFrameGPU->getDeviceROFOverlapTableView(),
mTimeFrameGPU->getDeviceArrayClusters(),
(const uint8_t**)mTimeFrameGPU->getDeviceArrayUsedClusters(),
mTimeFrameGPU->getDeviceArrayClustersIndexTables(),
mTimeFrameGPU->getDeviceROFrameClusters(),
mTimeFrameGPU->getDeviceArrayTrackingFrameInfo(),
mTimeFrameGPU->getDeviceTrackExtensionCandidates(),
mTimeFrameGPU->getDeviceTrackExtensionCandidateOffsets(),
mTimeFrameGPU->getDeviceActiveTrackExtensionHypotheses(),
mTimeFrameGPU->getDeviceNextTrackExtensionHypotheses(),
layerRadii,
layerxX0,
static_cast<int>(nTracks),
this->mTrkParams[iteration].NLayers,
this->mTrkParams[iteration].PhiBins,
beamWidth,
this->mTrkParams[iteration].PassFlags[IterationStep::TrackFollowerTop],
this->mTrkParams[iteration].PassFlags[IterationStep::TrackFollowerBot],
this->mBz,
this->mTrkParams[iteration].MaxChi2ClusterAttachment,
this->mTrkParams[iteration].MaxChi2NDF,
this->mTrkParams[iteration].TrackFollowerNSigmaCutPhi,
this->mTrkParams[iteration].TrackFollowerNSigmaCutZ,
mTimeFrameGPU->getDevicePropagator(),
this->mTrkParams[iteration].CorrType,
mTimeFrameGPU->getStream(0));
mTimeFrameGPU->createTrackExtensionResultsDevice(nTracks);
computeTrackExtensionResultsHandler<NLayers>(mTimeFrameGPU->getDeviceTrackExtensionStartTracks(),
mTimeFrameGPU->getDeviceTrackExtensionCandidates(),
mTimeFrameGPU->getDeviceTrackExtensionCandidateOffsets(),
mTimeFrameGPU->getDeviceTrackExtensionResults(),
mTimeFrameGPU->getDeviceArrayTrackingFrameInfo(),
layerxX0,
static_cast<int>(nTracks),
this->mTrkParams[iteration].NLayers,
this->mBz,
this->mTrkParams[iteration].MaxChi2ClusterAttachment,
this->mTrkParams[iteration].MaxChi2NDF,
mTimeFrameGPU->getDevicePropagator(),
this->mTrkParams[iteration].CorrType,
this->mTrkParams[iteration].ShiftRefToCluster,
mTimeFrameGPU->getStream(0));
mTimeFrameGPU->downloadTrackExtensionResultsDevice();

const auto& results = mTimeFrameGPU->getTrackExtensionResults();
for (int iResult{0}; iResult < static_cast<int>(results.size()); ++iResult) {
const auto& result = results[iResult];
if (!result.isValid()) {
continue;
}
auto candidate = result.candidate;
candidate.resultIndex = iResult;
if (candidatesPerTrack.add(candidate.trackIndex, candidate) < 0) {
continue;
}
}
}

template <int NLayers>
bool TrackerTraitsGPU<NLayers>::materializeTrackExtensionCandidate(TrackITSExt& track, const typename TrackerTraits<NLayers>::TrackExtensionCandidateN& candidate, const int iteration)
{
const auto& results = mTimeFrameGPU->getTrackExtensionResults();
if (candidate.resultIndex < 0 || candidate.resultIndex >= static_cast<int>(results.size())) {
return TrackerTraits<NLayers>::materializeTrackExtensionCandidate(track, candidate, iteration);
}
const auto& result = results[candidate.resultIndex];
if (!result.isValid() || result.candidate.trackIndex != candidate.trackIndex) {
return false;
}
track = result.track;
this->updateExtendedTrackTimeStamp(track, iteration);
uint32_t diff{0};
for (int iLayer{0}; iLayer < this->mTrkParams[iteration].NLayers; ++iLayer) {
if (candidate.addedClusters[iLayer] != constants::UnusedIndex) {
diff |= (0x1u << iLayer);
}
}
applyExtendedClustersPattern<NLayers>(track, diff);
return true;
}
};

template <int NLayers>
int TrackerTraitsGPU<NLayers>::getTFNumberOfClusters() const
Expand Down
Loading