fix: handle empty string with errors='replace'#372
Open
santhreal wants to merge 1 commit into
Open
Conversation
pinyin('', errors='replace') called ord('') and raised TypeError.
Treat length 0 like the multi-char path so replace returns '' and the
public API yields [], matching default/ignore.
📝 WalkthroughWalkthroughThe converter treats empty replacement input like other non-single-character inputs, avoiding ChangesEmpty input handling
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
converter._convert_nopinyin_chars hits TypeError when ord empty string errors=replace. This PR fixes the regression with a focused test covering the case.
Summary by CodeRabbit
Bug Fixes
Tests