Show a link to the Phabricator revision of each commit in the push list. - #9741
Open
fqueze wants to merge 1 commit into
Open
Show a link to the Phabricator revision of each commit in the push list.#9741fqueze wants to merge 1 commit into
fqueze wants to merge 1 commit into
Conversation
The Differential Revision trailer of the commit message is already part of the push data, so no additional request is needed to know it. Give the author initials a minimum width, so that the icons of the commits of a push are aligned.
✅ Deploy Preview for treeherder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Differential Revision trailer of the commit message is already part of the push data, so no additional request is needed to know it.
Give the author initials a minimum width, so that the icons of the commits of a push are aligned.
This is what this looks like on mozilla-central:
And this is what it looks like on one of my try pushes:
The main motivation for this change is that sometimes after addressing review comments on a patch, I send it to try one last time, and as soon as I see the try results are green, I want to land. For that I need to click the lando link on the phabricator page, and to access the phabricator page I need to either load first the bug, or the hg changeset; both are page loads that take a while. Given the phabricator revision id is included in the commit message that treeherder already parses, it makes sense to make the link accessible with a single click from the jobs view.
Additionally, I recently had a case where I was surprised I didn't get a quick review on a straightforward one line test fix. After a couple days I double checked and noticed I had forgotten to send that patch to phabricator, even though I had included it in all my recent try pushes. The missing icon there would have been immediately noticeable.