Bug-2038705: Migrate the get_commit to pygithub - #9739
Open
moijes12 wants to merge 7 commits into
Open
Conversation
Migrate get_commit to use pygithub
Add docstring to `get_commit` function
✅ Deploy Preview for treeherder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Added mocks for mocking PyGithub Commit objects
Added tests for testing get_commit scenarios: - Standard commit - Initial commit without parents - Commit without files
Update the tests in tests/changelog/ to reflect changes in github.py
Fixed return value of get_commit mock in tests and typo in committer.
prepare_responses no longer returns commit. It only patches get_commits
moijes12
marked this pull request as ready for review
July 31, 2026 08:54
Contributor
Author
|
@gmierz @Archaeopteryx This PR is now ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Introduced
get_commitmethod intreeeherder/utils/github.pyto use PyGithub object'sLocal Testing
update_changelog. See results below@gmierz @Archaeopteryx