Restore visited link color in ReactTable bodies. - #9725
Open
fqueze wants to merge 1 commit into
Open
Conversation
.rt-tbody a and a:visited have equal specificity (0,1,1), so the tie was broken by source order. treeherder-base.css is hoisted ahead of treeherder-custom-styles.css in the bundle (ui/App.jsx statically imports ./userguide/App, which is the first module to pull in base.css), which made the teal .rt-tbody rule win for visited links too. Adding .rt-tbody a:visited at specificity (0,2,1) restores purple for visited links in the intermittent failures tables and the Perfherder graph table view, while unvisited links keep #187c86. purple (#800080) on the table background is ~8.9:1, so this does not regress the contrast pass that motivated the teal rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.rt-tbody a and a:visited have equal specificity (0,1,1), so the tie was broken by source order. treeherder-base.css is hoisted ahead of treeherder-custom-styles.css in the bundle (ui/App.jsx statically imports ./userguide/App, which is the first module to pull in base.css), which made the teal .rt-tbody rule win for visited links too.
Adding .rt-tbody a:visited at specificity (0,2,1) restores purple for visited links in the intermittent failures tables and the Perfherder graph table view, while unvisited links keep #187c86. purple (#800080) on the table background is ~8.9:1, so this does not regress the contrast pass that motivated the teal rule.
My motivation for fixing this was the "open log viewer" links on https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2026-07-20&endday=2026-07-27&tree=all&bug=2057700 where seeing which failures I already looked at is really useful.