Check translator rights per string in All Projects - #4412
Merged
Conversation
useTranslator() builds its key from the URL's project:
const localeProject = `${code}-${slug}`;
if (Object.hasOwnProperty.call(translatorForProjects, localeProject)) { … }
In the All Projects view slug is "all-projects", and "uk-all-projects"
is never a key in `translatorForProjects`, so it falls through to the
locale-wide check, which is false for a per-project translator. Hence "Suggest".
The fix is to take the project from the entity instead.
Note that even today the submit approves, because the server already checks
permissions against the entity's own project.
eemeli
requested changes
Aug 17, 2026
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
flodolo
approved these changes
Aug 18, 2026
flodolo
left a comment
flodolo
left a comment
Collaborator
There was a problem hiding this comment.
Approving per conversation with Eemeli
eemeli
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4395.
useTranslator()builds its key from the URL:In the All Projects view slug is "all-projects", and e.g. "uk-all-projects" is never a key in
translatorForProjects, so it falls through to the locale-wide check, which is false for a per-project translator. Hence "Suggest".The fix is to take the project from the entity instead.
Note that even today the submit approves, because the server already checks permissions against the entity's own project.