tanfarming:ads/go_server_combined#849
Open
tanfarming wants to merge 3 commits into
Open
Conversation
…rver_pubsub Replace the separate `go_server_pubsub` outputter with a `transport` option on `go_server` (`-s transport=logging|pubsub|combined`, default logging), so there's one Go server outputter instead of one per transport. `combined` emits both the Cloud Logging and Pub/Sub APIs in a single file (sharing types) for gradual logging->pubsub migration.
akkomar
approved these changes
Jun 2, 2026
Member
akkomar
left a comment
akkomar
left a comment
There was a problem hiding this comment.
LGTM, this will make migration easier. Holding off merging until @tanfarming tests on his side.
Member
|
Can you give the PR a proper title so we know what this is about? |
Member
|
Same for the commit descriptions btw. |
badboy
reviewed
Jun 4, 2026
|
|
||
| ## Unreleased | ||
|
|
||
| - Go server: select the transport with the `transport` option on the `go_server` outputter to support gradual logging->pubsub migrations. ([DENG-9533](https://mozilla-hub.atlassian.net/browse/DENG-9533)) |
Member
There was a problem hiding this comment.
This should probably call out that it's ... uh ... basically breaking of what shipped in 19.2.0 (though I guess because there's only one consumer and that's to help them we're not actively breaking anyone)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one