chore(many): Upgrade nx#20740
Conversation
2b8953a to
b7e896c
Compare
vbudhram
left a comment
There was a problem hiding this comment.
@dschom I tested this locally and it runs fine. There does not seem to be a big increase in start up speed? Just the couple questions otw probably good to merge.
###########################################################
# ✅ Services ready in 123s (infrastructure was started earlier)
###########################################################
📍 Verifying started services:
fxa-content-server http://localhost:3030 OK
fxa-profile-server http://localhost:1111/__heartbeat__ OK
fxa-auth-server http://localhost:9000/__heartbeat__ OK
fxa-settings http://localhost:3000/settings/static/js/bundle.js OK
123done http://localhost:8080 OK
All started services responded.
💡 Run 'yarn ports' to see all service ports
###########################################################
| @@ -0,0 +1,105 @@ | |||
| { | |||
There was a problem hiding this comment.
It was auto-generated by nx. But I don't think we need it. I'll remove it.
| ] | ||
| }, | ||
| "build-fast": { | ||
| "dependsOn": ["prebuild", "^build", "build-l10n", "build-css", "build-copy-assets"] |
There was a problem hiding this comment.
build-copy-assets depends on build-ts so it I think it would lose the fast part of reading from source?
There was a problem hiding this comment.
Good catch. I'll clean this up.
| }, | ||
| "build-static": { | ||
| "cache": true, | ||
| "dependsOn": ["prebuild"], |
There was a problem hiding this comment.
This was called out in AI review, build-static should depend on build-l10n otherwise it could not bundle the ftl files.
|
Leaving a comment here from a slack thread, perhaps this fix can be rolled into this PR: The But, maybe there's a better way to handle this? The short version is just, content-server fails to boot because of an incomplete cache, forcing a full rebuild of the stack for functional-tests. |
6b22278 to
fa411da
Compare
Because: - Now that we are node 24, we can use the latest version of NX. - There are supposed perf benefits This Commit: - Upgrades NX, Next, Jest, and other support deps - Updates deprecated Jest assertions - Fixes a couple caching issues - Sets robust nx defaults that work well with our project - Removes NX commands from package.json 'scripts'. They are no longer permitted by nx.
Because
This pull request
Issue that this pull request solves
Closes: FXA-14141
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
There are some commands that now just have
exit 0in them. This is because dependencies are now managed by NX. This means you need use NX to run certain common commands. You can still run the 'sub' commands with yarn workspace directly.For example,
yarn workspace fxa-settings buildis nownx run fxa-settings:buildORyarn workspace fxa-settings:build-ts && yarn workspace fxa-settings build-css.