Conversation
mhammond
left a comment
There was a problem hiding this comment.
this seems slightly worrying if we later use viaduct for urls that may have pii, and it also seems like we are kinda abusing error reporting to record what it really just telemetry, but maybe we can suck this up if we remove it once we figure out what it going on? The other option would I guess be standard glean telemetry and we record the size of all successful downloads, but that's going to be more work and as of today probably needs to be in swift/kotlin.
@moztcampbell wdyt?
|
Good point about the PII. We could limit this to remote settings downloads. I believe those are the most likely culprits and the shouldn't have any PII in them. I actually think reporting these as errors is reasonable since the current viaduct API isn't really intended to be used for huge downloads. I would also be for recording the size of all downloads using some glean metric (maybe a histogram?), but I see that as complimentary. |
Pull Request checklist
[ci full]to the PR title.