Conversation
Pin our UniFFI crates to the head of https://github.com/bendk/uniffi-rs/tree/0.32-uniffi-bindgen-kotlin-jni. That branch is 0.32.1, with the uniffi_parse_rs and uniffi-bindgen-jni changes cherry-picked in.
bendk
force-pushed
the
bdk/push-nyxmurywznro
branch
from
September 16, 2026 22:58
9325098 to
81b570d
Compare
mhammond
approved these changes
Sep 16, 2026
Member
|
probably do need the dependency check job fixed. Might also be mildly better if the commit was on a branch on origin rather than yours, but not a big deal either way |
Contributor
Author
Good point, let's use #7607 instead which is for a mozilla branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin our UniFFI crates to the head of
https://github.com/bendk/uniffi-rs/tree/0.32-uniffi-bindgen-kotlin-jni. That branch is 0.32.1, with the uniffi_parse_rs and uniffi-bindgen-jni changes cherry-picked in.
The idea here is to use uniffi-bindgen-kotlin-jni without doing a UniFFI release. This way we can test things out without waiting for Glean to take that new release. I tested this with a local build and it worked for me.
There's a decent chance that we'll have to back this out because it creates issues, so let's not merge this until:
Pull Request checklist
[ci full]to the PR title.