Skip to content

Switch to uniffi-bindgen-kotlin-jni - #7605

Closed
bendk wants to merge 1 commit into
mozilla:mainfrom
bendk:bdk/push-nyxmurywznro
Closed

bendk wants to merge 1 commit into
mozilla:mainfrom
bendk:bdk/push-nyxmurywznro

Conversation

@bendk

@bendk bendk commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Pin our UniFFI crates to the head of
https://github.com/bendk/uniffi-rs/tree/0.32-uniffi-bindgen-kotlin-jni. That branch is 0.32.1, with the uniffi_parse_rs and uniffi-bindgen-jni changes cherry-picked in.

The idea here is to use uniffi-bindgen-kotlin-jni without doing a UniFFI release. This way we can test things out without waiting for Glean to take that new release. I tested this with a local build and it worked for me.

There's a decent chance that we'll have to back this out because it creates issues, so let's not merge this until:

  • The Glean update has had time to settle down
  • We're out of the engineering summit

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Pin our UniFFI crates to the head of
https://github.com/bendk/uniffi-rs/tree/0.32-uniffi-bindgen-kotlin-jni.
That branch is 0.32.1, with the uniffi_parse_rs and uniffi-bindgen-jni
changes cherry-picked in.
@bendk
bendk force-pushed the bdk/push-nyxmurywznro branch from 9325098 to 81b570d Compare September 16, 2026 22:58
@mhammond

Copy link
Copy Markdown
Member

probably do need the dependency check job fixed. Might also be mildly better if the commit was on a branch on origin rather than yours, but not a big deal either way

@bendk

bendk commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

probably do need the dependency check job fixed. Might also be mildly better if the commit was on a branch on origin rather than yours, but not a big deal either way

Good point, let's use #7607 instead which is for a mozilla branch.

@bendk bendk closed this Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants