[Certora] fix delegation spec - #114
Open
QGarchery wants to merge 1 commit into
Open
Conversation
QGarchery
commented
Aug 26, 2026
Comment on lines
+217
to
+218
| requireInvariant sumOfVotesStartsAtZero(); | ||
| requireInvariant sumOfVotesMonotone(); |
Contributor
Author
There was a problem hiding this comment.
Needed to show that sumOfVotes is non-negative. It's easy to construct a counter-example otherwise
QGarchery
commented
Aug 26, 2026
| rule updatedDelegatedVPLTEqTotalSupply(address from, address to) { | ||
| requireInvariant sumOfVotesStartsAtZero(); | ||
| requireInvariant sumOfVotesMonotone(); | ||
| requireInvariant delegatedVotingPowerLTEqTotalVotingPower(); |
Contributor
Author
There was a problem hiding this comment.
the last one is needed for the delegatee(from) == 0 case. If it doesn't hold because one account has a greater balance than the total supply, that account could delegate to itself and it would also break the property of this rule
bhargavbh
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the rule that is failing was never going through. It was introduced in #105, but this PR did not run the CI