Skip to content

ci(checks): bump foundry-toolchain to v1.9.1 for foundryup v2 - #177

Closed
julien-devatom wants to merge 1 commit into
mainfrom
ci-foundry-toolchain-v191-f609c5
Closed

ci(checks): bump foundry-toolchain to v1.9.1 for foundryup v2#177
julien-devatom wants to merge 1 commit into
mainfrom
ci-foundry-toolchain-v191-f609c5

Conversation

@julien-devatom

@julien-devatom julien-devatom commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

The SHA-pinned v1-era foundry-rs/foundry-toolchain downloads the live foundryup installer and then runs the installed foundryup through bash. On 2026-08-25 (~15:24Z) the installer began shipping foundryup as a compiled binary, so the Test job fails repo-wide — main, #174, and #176 alike — with:

/home/runner/.foundry/bin/foundryup: cannot execute binary file
Error: Command failed: bash "/home/runner/.foundry/bin/foundryup" --install 1.5.1

v1.9.1 fixes both failure modes: it pins the installer to a fixed foundry-rs/foundryup commit (no live-installer drift) and executes the installed foundryup natively instead of bash-ing it. Our step's only input (version: v1.5.1) is forwarded to foundryup --install unchanged, so the anvil 1.5.1 pin and its nonce-behavior rationale are untouched.

Verification: this PR's own Test check runs the bumped action — a green Install Foundry step (and the downstream forge/vitest steps actually executing) is the proof; the failure is CI-only and not locally reproducible.

🤖 Generated with Claude Code

The pinned v1-era action downloads the live foundryup installer and runs
the installed foundryup through bash. On 2026-08-25 the installer began
shipping foundryup as a compiled binary, so every Test job on every
branch fails with 'cannot execute binary file' at the Install Foundry
step. v1.9.1 pins the installer to a fixed foundry-rs/foundryup commit
and executes foundryup natively, and it forwards the existing
version: v1.5.1 input unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@julien-devatom julien-devatom self-assigned this Aug 25, 2026
@julien-devatom
julien-devatom marked this pull request as ready for review August 25, 2026 18:20
@julien-devatom

Copy link
Copy Markdown
Collaborator Author

@codex review

@julien-devatom

Copy link
Copy Markdown
Collaborator Author

@prd-carapulse[bot] can you review and approve if all good

@prd-carapulse

prd-carapulse Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Approved PR #177.

Scope: One-line CI action bump in .github/workflows/checks.yml
Pin verified: 908c540300062bd5a7e473851cdb4282204cee09 resolves exactly to foundry-toolchain v1.9.1
Checks: Test, Lint, Typecheck, Dead-Code, and Notify passed
Review: Devin reported no issues
Approval: Posted by prd-carapulse[bot] on head afce29cd3cbc170b35abb6c23c570788be6820d0

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@prd-carapulse prd-carapulse Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the single-file CI pin. The ref resolves exactly to foundry-toolchain v1.9.1, which matches the stated foundryup v2 fix. Test, Lint, Typecheck, and Dead-Code checks pass; no blocking correctness or security issues found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: afce29cd3c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants