fix(helm): return instead of exit in process_chart#102
Closed
rguichard wants to merge 1 commit into
Closed
Conversation
process_chart() is invoked directly in the sequential loop (`if ! process_chart "$chart"`), so `exit` terminated the entire script after the first chart — remaining charts were never validated and the summary was never printed. Use `return` so the caller can aggregate failures and reach the summary. Behaviour in the parallel path (where the function runs in a `parallel`-spawned subshell) is unchanged. Addresses Aikido finding on validate-helm-charts.sh. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an Aikido finding on PR #90 (
validate-helm-charts.sh).process_chart()is invoked directly in the sequential loop (if ! process_chart "$chart"), so the trailingexitterminated the entire script after the first chart — remaining charts were never validated and the summary was never printed. The threeexitstatements are changed toreturnso the caller aggregates failures and reaches the summary. The parallel path (function runs in aparallel-spawned subshell) is unaffected.🤖 Generated with Claude Code