Skip to content

Fill and review API documentation - #209

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
automation/write-api-docs
Open

Fill and review API documentation#209
github-actions[bot] wants to merge 1 commit into
mainfrom
automation/write-api-docs

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Summary

Filled To be added. documentation placeholders for the newly-shipped Graphite GPU backend APIs and the new async read-pixels members, then reviewed the existing docs for factual accuracy against the C# source.

  • Filled: 27 type files (250 doc fields across summaries, params, returns, values, and remarks).
    • New Graphite types: SKGraphiteContext, SKGraphiteRecorder, SKGraphiteRecording, SKGraphiteBackendTexture, SKGraphiteTextureInfo, SKGraphiteImageCache, backend contexts (Vk/Mtl/Dawn) and their init structs, options/submit/insert-recording/Vk-texture info structs, the SKGraphiteBackend and SKGraphiteInsertStatus enums, and the three Graphite delegates.
    • Async read-pixels: SKImageReadPixelsResult, SKImageRescaleGamma, SKImageRescaleMode, plus new SKImage/SKSurface/SKGraphiteContext RequestReadPixels/FromTexture/ToTextureImage/Create overloads.
    • New members on existing types: GRContext.CheckAsyncWorkCompletion, GRVkExtensions constructor.
  • Reviewed: all 27 touched files — verified every claim, signature, parameter, and default (e.g. CreateRecorder(-1) sentinel, non-yielding Dawn submit constraints, callback-scoped result lifetime) against skiasharp/binding/SkiaSharp/**. Added one correct, non-obsolete usage example on the central SKGraphiteContext type.

Findings summary

Severity Count
CRITICAL 0
HIGH 0
MEDIUM 0
LOW 0

No factual, example, or quality defects were found in the reviewed docs beyond the missing content that was filled. All fixes were placeholder fills; nothing was deferred.

FINDING | severity=none | file=- | docId=- | category=- | message=No correctness defects found; 27 type files filled and reviewed against source.

Validation

dotnet cake --target=docs-format-docs reports 0/453 missing types, 0/5197 missing members, 0 findings, 0 errors. All touched XML is well-formed.

Generated by Auto API Docs Writer · opus48 · 541.3 AIC · ⌖ 23.6 AIC · ⊞ 9K ·

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@learn-build-service-prod

Copy link
Copy Markdown
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit b93577c:

⚠️ Validation status: warnings

File Status Preview URL Details
SkiaSharpAPI/SkiaSharp/GRContext.xml ⚠️Warning Details
SkiaSharpAPI/SkiaSharp/GRVkExtensions.xml ⚠️Warning Details
SkiaSharpAPI/SkiaSharp/SKImage.xml ⚠️Warning Details
SkiaSharpAPI/SkiaSharp/SKSurface.xml ⚠️Warning Details
SkiaSharpAPI/SkiaSharp/SKGraphiteBackend.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteBackendTexture.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteContext.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteContextOptions.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteDawnBackendContext.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteDawnBackendContextInit.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteFindOrCreateImageDelegate.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteImageCache.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteInsertRecordingInfo.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteInsertStatus.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteMtlBackendContext.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteMtlBackendContextInit.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteRecorder.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteRecording.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteReleaseDelegate.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteSubmitInfo.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteTextureInfo.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteVkBackendContext.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteVkGetProcedureAddressDelegate.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKGraphiteVkTextureInfo.xml ✅Succeeded
SkiaSharpAPI/SkiaSharp/SKImageReadPixelsResult.xml ✅Succeeded

This comment lists only the first 25 files in the pull request.

SkiaSharpAPI/SkiaSharp/GRContext.xml

  • Line 0, Column 0: [Warning: ECMA2Yaml_UidAssembly_NotMatched] SkiaSharp.GRContext's moniker skiasharp can't match any assembly.

SkiaSharpAPI/SkiaSharp/GRVkExtensions.xml

  • Line 0, Column 0: [Warning: ECMA2Yaml_UidAssembly_NotMatched] SkiaSharp.GRVkExtensions's moniker skiasharp can't match any assembly.

SkiaSharpAPI/SkiaSharp/SKImage.xml

  • Line 0, Column 0: [Warning: ECMA2Yaml_UidAssembly_NotMatched] SkiaSharp.SKImage's moniker skiasharp can't match any assembly.

SkiaSharpAPI/SkiaSharp/SKSurface.xml

  • Line 0, Column 0: [Warning: ECMA2Yaml_UidAssembly_NotMatched] SkiaSharp.SKSurface's moniker skiasharp can't match any assembly.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants