chore(NODE-7765): add default timeouts - #5036
Open
PavelSafronov wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Evergreen configuration for the MongoDB Node.js driver CI to enforce a consistent default idle timeout across tasks and to collect diagnostic information when timeouts occur, aiming to reduce long-running stalled builds.
Changes:
- Set a global default
timeout_secs: 300(idle timeout) and remove redundant per-command 300s timeouts. - Replace the timeout handler with a diagnostic
shell.execscript to capture directory/process/socket state on timeout. - Increase benchmark idle timeout to
timeout_secs: 600to accommodate longer silent benchmark runs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .evergreen/config.yml | Applies the generated Evergreen config updates: global idle timeout, updated timeout diagnostics handler, and per-command overrides (including benchmarks). |
| .evergreen/config.in.yml | Source template for Evergreen config: documents and defines the global timeout policy, diagnostics on timeout, and command-specific timeout overrides. |
Suppressed comments (2)
.evergreen/config.in.yml:293
timeout_secs: 60makes the compile step fail if it is silent for 60s. Inrun-typescript.sh,npm run build:tscan be quiet whiletscworks, and compilation can exceed 60s on slower/contended hosts, leading to flaky CI timeouts. Consider using the 300s default (or adding periodic output).
"compile driver":
- command: subprocess.exec
type: test
timeout_secs: 60
params:
.evergreen/config.in.yml:250
timeout_secs: 60makes the TypeScript type-check command fail if it is silent for 60s.run-typescript.shrunsnode $TSC mongodb.d.ts ...which can be silent until completion and may exceed 60s on slower machines, causing intermittent timeouts. Consider using the 300s default (or adding periodic output).
"check types":
- command: subprocess.exec
type: test
timeout_secs: 60
params:
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+21
to
+24
| # A stalled task is usually a leaked child process still holding the command's | ||
| # stdout open, so dump the process tables before the host is reclaimed. On Windows | ||
| # `ps` only lists cygwin processes, hence `tasklist` for native ones. Every command | ||
| # is guarded so the handler cannot itself fail or hang. |
Contributor
Author
There was a problem hiding this comment.
Updated comment.
Comment on lines
220
to
224
| "run lint checks": | ||
| - command: subprocess.exec | ||
| type: test | ||
| timeout_secs: 60 | ||
| params: |
Contributor
Author
There was a problem hiding this comment.
The tasks resolve in under 15 seconds most of the time, this isn't an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR adds a default
timeout_secs: 300to all tasks, which means that if the task produces no stdout/stderr output for 5 minutes, the task will be killed.Notes for Reviewers
Changes:
What is the motivation for this change?
Timeouts weren't correctly set in evergreen config, so tasks only timed out after 2 hours (default timeout value).
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript