chore(NODE-7558): sync spec tests by johnmtll · Pull Request #5029 · mongodb/node-mongodb-native

johnmtll · 2026-08-21T21:44:25Z

Description

Summary of Changes

Syncs spec test files as per the AC of NODE-7558.

Notes for Reviewers

What is the motivation for this change?

Release Highlight

Release notes highlight

Double check the following

Lint is passing (npm run check:lint)
Self-review completed using the steps outlined here
PR title follows the correct format: type(NODE-xxxx)[!]: description
- Example: feat(NODE-1234)!: rewriting everything in coffeescript
Changes are covered by tests
New TODOs have a related JIRA ticket

evergreen-ci-prod · 2026-08-21T21:44:27Z

There is an existing patch(es) for this commit SHA:

Evergreen patch with PR

Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'.

This reverts commit e087300.

Copilot

Pull request overview

Syncs vendored MongoDB specification test fixtures to align this driver’s test corpus with the upstream specs (NODE-7558). This primarily updates/removes unified spec test YAML/JSON files under test/spec/, plus a few small comment-only cleanups in integration prose tests.

Changes:

Updated/trimmed multiple unified spec test fixtures (CRUD hint behavior, dots/dollars behavior, redaction tests, SDAM templates, etc.) to match upstream.
Removed several pre-4.2 / pre-3.6 / maxWireVersion-related spec test files that are no longer present upstream.
Minor comment-only adjustments in a few integration prose test files.

Reviewed changes

Copilot reviewed 76 out of 76 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/spec/unified-test-format/valid-pass/entity-find-cursor.yml	Spec fixture sync (comment removal)
test/spec/server-discovery-and-monitoring/errors/pre-42.yml.template	Removed obsolete SDAM error template fixture
test/spec/read-write-concern/operation/default-write-concern-3.4.yml	Spec fixture sync (comment update)
test/spec/read-write-concern/operation/default-write-concern-3.2.yml	Spec fixture sync (comment clarified)
test/spec/read-write-concern/operation/default-write-concern-2.6.yml	Spec fixture sync (comment removal)
test/spec/crud/unified/updateOne-hint-unacknowledged.yml	Spec fixture sync (removed pre-4.2 cases; anchor relocation)
test/spec/crud/unified/updateOne-hint-unacknowledged.json	Spec fixture sync (removed pre-4.2 cases)
test/spec/crud/unified/updateOne-hint-serverError.yml	Removed obsolete spec fixture
test/spec/crud/unified/updateOne-hint-serverError.json	Removed obsolete spec fixture
test/spec/crud/unified/updateOne-hint-clientError.yml	Removed obsolete spec fixture
test/spec/crud/unified/updateOne-hint-clientError.json	Removed obsolete spec fixture
test/spec/crud/unified/updateMany-hint-unacknowledged.yml	Spec fixture sync (removed pre-4.2 cases; anchor relocation)
test/spec/crud/unified/updateMany-hint-unacknowledged.json	Spec fixture sync (removed pre-4.2 cases)
test/spec/crud/unified/updateMany-hint-serverError.yml	Removed obsolete spec fixture
test/spec/crud/unified/updateMany-hint-serverError.json	Removed obsolete spec fixture
test/spec/crud/unified/updateMany-hint-clientError.yml	Removed obsolete spec fixture
test/spec/crud/unified/updateMany-hint-clientError.json	Removed obsolete spec fixture
test/spec/crud/unified/replaceOne-hint-unacknowledged.yml	Spec fixture sync (removed pre-4.2 cases; anchor relocation)
test/spec/crud/unified/replaceOne-hint-unacknowledged.json	Spec fixture sync (removed pre-4.2 cases)
test/spec/crud/unified/replaceOne-dots_and_dollars.yml	Spec fixture sync (removed pre-3.6 server-error cases)
test/spec/crud/unified/replaceOne-dots_and_dollars.json	Spec fixture sync (removed pre-3.6 server-error cases)
test/spec/crud/unified/insertOne-dots_and_dollars.yml	Spec fixture sync (removed pre-3.6 server-error case)
test/spec/crud/unified/insertOne-dots_and_dollars.json	Spec fixture sync (removed pre-3.6 server-error case)
test/spec/crud/unified/findOneAndUpdate.yml	Spec fixture sync (comment shortened)
test/spec/crud/unified/findOneAndUpdate-let.yml	Spec fixture sync (comment removal)
test/spec/crud/unified/findOneAndUpdate-hint-clientError.yml	Removed obsolete spec fixture
test/spec/crud/unified/findOneAndUpdate-hint-clientError.json	Removed obsolete spec fixture
test/spec/crud/unified/findOneAndReplace-upsert.yml	Spec fixture sync (comment shortened)
test/spec/crud/unified/findOneAndReplace-let.yml	Spec fixture sync (comment removal)
test/spec/crud/unified/findOneAndReplace-hint-clientError.yml	Removed obsolete spec fixture
test/spec/crud/unified/findOneAndReplace-hint-clientError.json	Removed obsolete spec fixture
test/spec/crud/unified/findOneAndReplace-dots_and_dollars.yml	Spec fixture sync (removed pre-3.6 server-error cases)
test/spec/crud/unified/findOneAndReplace-dots_and_dollars.json	Spec fixture sync (removed pre-3.6 server-error cases)
test/spec/crud/unified/findOneAndDelete-let.yml	Spec fixture sync (comment removal)
test/spec/crud/unified/findOneAndDelete-hint-clientError.yml	Removed obsolete spec fixture
test/spec/crud/unified/findOneAndDelete-hint-clientError.json	Removed obsolete spec fixture
test/spec/crud/unified/find-allowdiskuse-clientError.yml	Removed obsolete spec fixture
test/spec/crud/unified/find-allowdiskuse-clientError.json	Removed obsolete spec fixture
test/spec/crud/unified/deleteOne-hint-clientError.yml	Removed obsolete spec fixture
test/spec/crud/unified/deleteOne-hint-clientError.json	Removed obsolete spec fixture
test/spec/crud/unified/deleteMany-hint-clientError.yml	Removed obsolete spec fixture
test/spec/crud/unified/deleteMany-hint-clientError.json	Removed obsolete spec fixture
test/spec/crud/unified/db-aggregate-write-readPreference.yml	Spec fixture sync (comment updates)
test/spec/crud/unified/bulkWrite-updateOne-hint-unacknowledged.yml	Spec fixture sync (removed pre-4.2 cases; anchor relocation)
test/spec/crud/unified/bulkWrite-updateOne-hint-unacknowledged.json	Spec fixture sync (removed pre-4.2 cases)
test/spec/crud/unified/bulkWrite-updateMany-hint-unacknowledged.yml	Spec fixture sync (removed pre-4.2 cases; anchor relocation)
test/spec/crud/unified/bulkWrite-updateMany-hint-unacknowledged.json	Spec fixture sync (removed pre-4.2 cases)
test/spec/crud/unified/bulkWrite-update-hint-serverError.yml	Removed obsolete spec fixture
test/spec/crud/unified/bulkWrite-update-hint-serverError.json	Removed obsolete spec fixture
test/spec/crud/unified/bulkWrite-update-hint-clientError.yml	Removed obsolete spec fixture
test/spec/crud/unified/bulkWrite-update-hint-clientError.json	Removed obsolete spec fixture
test/spec/crud/unified/bulkWrite-replaceOne-hint-unacknowledged.yml	Spec fixture sync (removed pre-4.2 cases; anchor relocation)
test/spec/crud/unified/bulkWrite-replaceOne-hint-unacknowledged.json	Spec fixture sync (removed pre-4.2 cases)
test/spec/crud/unified/bulkWrite-replaceOne-dots_and_dollars.yml	Spec fixture sync (removed pre-3.6 server-error cases)
test/spec/crud/unified/bulkWrite-replaceOne-dots_and_dollars.json	Spec fixture sync (removed pre-3.6 server-error cases)
test/spec/crud/unified/bulkWrite-delete-hint-clientError.yml	Removed obsolete spec fixture
test/spec/crud/unified/bulkWrite-delete-hint-clientError.json	Removed obsolete spec fixture
test/spec/crud/unified/bulkWrite-arrayFilters-clientError.yml	Removed obsolete spec fixture
test/spec/crud/unified/bulkWrite-arrayFilters-clientError.json	Removed obsolete spec fixture
test/spec/command-logging-and-monitoring/monitoring/redacted-commands.yml	Spec fixture sync (removed copydb* cases)
test/spec/command-logging-and-monitoring/monitoring/redacted-commands.json	Spec fixture sync (removed copydb* cases)
test/spec/command-logging-and-monitoring/monitoring/pre-42-server-connection-id.yml	Removed obsolete spec fixture
test/spec/command-logging-and-monitoring/monitoring/pre-42-server-connection-id.json	Removed obsolete spec fixture
test/spec/command-logging-and-monitoring/logging/redacted-commands.yml	Spec fixture sync (removed copydb* cases)
test/spec/command-logging-and-monitoring/logging/redacted-commands.json	Spec fixture sync (removed copydb* cases)
test/spec/command-logging-and-monitoring/logging/pre-42-server-connection-id.yml	Removed obsolete spec fixture
test/spec/command-logging-and-monitoring/logging/pre-42-server-connection-id.json	Removed obsolete spec fixture
test/spec/client-side-operations-timeout/retryability-timeoutMS.yml	Spec fixture sync (comment removal)
test/spec/client-side-operations-timeout/error-transformations.yml	Spec fixture sync (comment removal)
test/spec/client-side-encryption/tests/unified/maxWireVersion.yml	Removed obsolete spec fixture
test/spec/client-side-encryption/tests/unified/maxWireVersion.json	Removed obsolete spec fixture
test/spec/client-side-encryption/tests/legacy/maxWireVersion.yml	Removed obsolete legacy spec fixture
test/spec/client-side-encryption/tests/legacy/maxWireVersion.json	Removed obsolete legacy spec fixture
test/integration/crud/crud.prose.test.ts	Comment-only cleanup in prose test
test/integration/connections-survive-step-down/connections_survive_step_down.prose.test.ts	Comment-only cleanup in prose test
test/integration/change-streams/change_streams.prose.test.ts	Comment-only cleanup in prose test

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

PavelSafronov

The original DRIVERS PR included changes to the following files, which are not included in this PR:

source/crud/tests/unified/aggregate-let.yml
source/crud/tests/unified/aggregate-write-readPreference.yml

#5029 (review)

#5029 (comment)

johnmtll added 4 commits August 20, 2026 21:01

chore: delete 4.2 template

69b6d2e

chore: sync dropped files

081e3b3

chore: sync updated files

b3272d4

chore: align with updated prose tests

1223aef

johnmtll added 2 commits August 21, 2026 17:45

fix: duplicate evg commit

e087300

Revert "fix: duplicate evg commit"

79de4a4

This reverts commit e087300.

johnmtll marked this pull request as ready for review August 21, 2026 21:46

johnmtll requested a review from a team as a code owner August 21, 2026 21:46

Copilot AI lite review requested due to automatic review settings August 21, 2026 21:46

Copilot started reviewing on behalf of johnmtll August 21, 2026 21:46 View session

Copilot AI reviewed Aug 21, 2026

View reviewed changes

PavelSafronov requested changes Aug 21, 2026

View reviewed changes

Comment thread test/spec/server-discovery-and-monitoring/errors/pre-42.yml.template Outdated

johnmtll added 3 commits August 24, 2026 10:25

chore: address comment

9714080

#5029 (review)

chore: address comment

3d4d2c9

#5029 (comment)

chore: lint

8e0e62d

PavelSafronov self-assigned this Aug 24, 2026

PavelSafronov added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 24, 2026

PavelSafronov approved these changes Aug 24, 2026

View reviewed changes

PavelSafronov added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 24, 2026

Navigation Menu

Uh oh!

chore(NODE-7558): sync spec tests - #5029

chore(NODE-7558): sync spec tests#5029
johnmtll wants to merge 9 commits into
mainfrom
NODE-7558/tests-sync

johnmtll commented Aug 21, 2026 •

edited

Loading

Uh oh!

evergreen-ci-prod Bot commented Aug 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

PavelSafronov left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

johnmtll commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary of Changes

Notes for Reviewers

What is the motivation for this change?

Release Highlight

Release notes highlight

Double check the following

Uh oh!

evergreen-ci-prod Bot commented Aug 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

PavelSafronov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

johnmtll commented Aug 21, 2026 •

edited

Loading