fix(resmoke): avoid mutable default for shell_options in CheckIdleCursors - #1823
Open
shoemoney wants to merge 1 commit into
Open
fix(resmoke): avoid mutable default for shell_options in CheckIdleCursors#1823shoemoney wants to merge 1 commit into
shoemoney wants to merge 1 commit into
Conversation
…sors
Fix verified RED->GREEN. Mutable default shell_options={} in CheckIdleCursors leaks TestData across hook instances at check_idle_cursors.py:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shell_options={}atcheck_idle_cursors.py:13is declared as a default argument. It is shared across hook instances, soafter_testmutatingglobal_varsandTestDataleaksTestDatabetween them.The default becomes
None. No other files are touched.Verified RED to GREEN: before the fix the default is an empty dict literal, after the fix it is
Nonewith a guard that creates a fresh dict. The file compiles withpy_compileand the AST check passes.