Evergreen#2012
Draft
rozza wants to merge 6 commits into
Draft
Conversation
Member
Author
nhachicha
reviewed
Jul 9, 2026
|
|
||
| // Run gpg capturing both streams; on non-zero exit throw with the captured output appended so the | ||
| // underlying gpg diagnostic is visible instead of Gradle's opaque "finished with non-zero exit value N". | ||
| fun runGpg(vararg args: String, onFailure: (String) -> String) { |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies a set of Evergreen/CI robustness fixes, primarily targeting Windows-host differences (GPG path semantics and environment detection) and reducing shutdown-time test flakiness, while also adjusting MQL asString functional tests to align with server-version behavior.
Changes:
- Update
mongodb-crypttarball signature verification to translate Windows paths for Cygwingpgand improve error diagnostics. - Adjust MQL
asStringnested conversion tests to use 8.3 as the version boundary. - Harden Evergreen environment setup and sync test shutdown cleanup to avoid failures from missing env vars / shutdown-time exceptions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
mongodb-crypt/build.gradle.kts |
Adds Windows/Cygwin-aware GPG path translation and improved GPG exec diagnostics for libmongocrypt signature verification. |
driver-sync/src/test/functional/com/mongodb/client/Fixture.java |
Wraps shutdown-hook database drop in a try/catch to prevent shutdown-time failures. |
driver-core/src/test/functional/com/mongodb/client/model/mql/TypeMqlValuesFunctionalTest.java |
Shifts asString nested test gating from 8.2 to 8.3 to match server behavior. |
.evergreen/setup-env.bash |
Defaults OS when unset to avoid set -u unbound variable failures, improving cross-platform behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
FYI A number of tests (timing related) seem to be struggling with windows. Reviewing. |
rozza
force-pushed
the
evergreen
branch
2 times, most recently
from
July 22, 2026 16:32
a310f10 to
5398b95
Compare
rozza
marked this pull request as draft
July 23, 2026 09:15
The gpg on the Evergreen Windows hosts is a Cygwin build that only understands POSIX paths. Handed native Windows paths (C:\dir) it treats them as relative, mangles the keyring location, and fails to find a writable keyring. Translate drive-letter paths to the Cygwin form (C:\dir -> /cygdrive/c/dir) on Windows for every gpg path argument (homedir, public key, signatures, tarballs); other platforms are unchanged. Also surface gpg stdout/stderr and the gnupgHome/publicKey state on failure so future gpg issues are diagnosable instead of showing only Gradle's opaque non-zero exit value.
Should fix publishing of snapshots. JAVA-6057
Brings it inline with the reactive streams shutdown hook. Ensures tests don't fail on shutdown with a DatabaseDropPending exception
CSOT prose and unified tests are calibrated for fast Linux CI hosts; on Windows + TLS a fresh client's connection establishment consumes the tight timeout budgets, so a command under test times out during setup (or the wrong command times out). Add ClusterFixture.isWindows()/scaleForWindows() plus a unified scaleForWindows(entities, definition, factor) transform, and apply Windows-only timeout scaling (and a value-agnostic floor for the success-family getMore-refresh tests) to the affected CSOT tests. The non-Windows RTT retries are retained for other TLS runs. All Windows CSOT adjustments are grouped at the end of the CSOT section.
…ationTimeoutException With timeoutMS set, socket timeouts should surface as MongoOperationTimeoutException. The read path translates a bare java.net.SocketTimeoutException, but the write path only handled MongoSocketWriteTimeoutException, so a bare SocketTimeoutException during a send fell through to MongoSocketWriteException. On Windows + TLS a blocking SSLSocket write surfaces the socket read-timeout as a bare SocketTimeoutException, reproducing the inconsistency. In throwTranslatedWriteException, when timeoutMS is set, wrap a bare SocketTimeoutException in a MongoSocketWriteTimeoutException and then MongoOperationTimeoutException, mirroring translateReadException. Confined to the timeoutMS path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various build fixes for evergreen.