feat(ipa): Declutter the guideline header and add a collapsible Details group#71
Open
andmatei wants to merge 1 commit into
Open
feat(ipa): Declutter the guideline header and add a collapsible Details group#71andmatei wants to merge 1 commit into
andmatei wants to merge 1 commit into
Conversation
andmatei
requested review from
andreaangiolillo,
drinkbird,
lovisaberggren,
matt-condon,
saisundar,
wtrocki and
yelizhenden-mdb
andmatei
force-pushed
the
andmatei/guideline-ui-declutter
branch
3 times, most recently
from
209156e to
f7aaa0a
Compare
andmatei
force-pushed
the
andmatei/guideline-ui-declutter
branch
4 times, most recently
from
bd5f946 to
9cbfed8
Compare
andmatei
changed the title
andmatei
force-pushed
the
andmatei/guideline-ui-declutter
branch
from
9cbfed8 to
e092963
Compare
…ls group - Remove the Informational/Enforced badge from the guideline header; the `informational` field stays in the metadata. - Add <Guideline.Details>: a collapsible "Details" accordion (overridable title) that authors wrap a guideline's examples + workflow in, so the rule's prose stays visible and the supporting detail collapses below it. - <Guideline> renders its children verbatim — no child introspection. - Show workflows site-wide (showWorkflows: true) now that they live inside the Details accordion. - Restructure the dev fixtures page; wrap IPA-100's example in Details. - Update the VS Code authoring snippets to wrap examples/workflow in <Guideline.Details> (and add a guideline-details snippet); use the 3-digit ID placeholder.
andmatei
force-pushed
the
andmatei/guideline-ui-declutter
branch
from
e092963 to
8347f52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before → After
What changed
Informational/Enforcedbadge (theinformationalfield stays in the metadata). The header now hides when it has nothing to show, and "Lint rule ↗" sits next to the state badge instead of far-right.<Guideline.Details>: wrap a guideline's<Example.*>+<Workflow>in it and they collapse into one "Details" accordion below the prose (overridabletitle).<Guideline>renders its children verbatim.showWorkflows: true; workflows render inside the accordion.guideline-lintable,guideline-unlintable,guideline-details).ipa/dev/component-fixtures.mdxrestructured: a full example up top, then one section per component.