Skip to content

Building binary fails on Windows with Node 22.x #61

Description

@asamuzaK

Node 22.x is now active LTS.
Building a binary fails because vs2019 is no longer supported.

Log

 Running cmd /c .\vcbuild.bat no-shared-roheap projgen release vs2019 link-module ./lib-boxednode/index.js ...
Error: invalid command line option `vs2019`.
  ✖  Failed: Command failed: cmd /c .\vcbuild.bat no-shared-roheap projgen release vs2019 link-module ./lib-boxednode/index.js (code 1)
Error: Command failed: cmd /c .\vcbuild.bat no-shared-roheap projgen release vs2019 link-module ./lib-boxednode/index.js (code 1)
    at Object.spawnBuildCommand (D:\a\withExEditorHost\withExEditorHost\node_modules\boxednode\lib\helpers.js:34:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async compileNode (D:\a\withExEditorHost\withExEditorHost\node_modules\boxednode\lib\index.js:222:9)
    at async writeMainFileAndCompile (D:\a\withExEditorHost\withExEditorHost\node_modules\boxednode\lib\index.js:326:16)
    at async compileJSFileAsBinaryImpl (D:\a\withExEditorHost\withExEditorHost\node_modules\boxednode\lib\index.js:330:22)
    at async compileJSFileAsBinary (D:\a\withExEditorHost\withExEditorHost\node_modules\boxednode\lib\index.js:381:9)
    at async main (D:\a\withExEditorHost\withExEditorHost\node_modules\boxednode\bin\boxednode.js:46:5)
Error: Process completed with exit code 1.

#51 should fix this.
Until then, --make-args="vs2022" as a workaround.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions