Add Nix dev environment, replace husky with git hooks#44
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9977771227
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
amackillop
force-pushed
the
austin_add-flake-1
branch
2 times, most recently
from
5028101 to
ccaa875
Compare
Sets up a Nix-based dev environment (fenix + crane) and swaps the husky pre-commit hook for a tracked .githooks directory wired via core.hooksPath. Husky and lint-staged weren't doing much. The only tracked JS is index.js and index.d.ts, both auto-generated by NAPI-RS with eslint-disable and prettier-ignore at the top. lint-staged was formatting code that opts out of linting, while the Rust source got nothing. The new hook just runs `just check`, which runs `nix flake check` (fmt, clippy, build). Cargo.lock is now tracked. Crane vendors git deps from it so it has to be visible to Nix, and for a library shipped via npm tracking the lockfile is the right call anyway as binaries are produced.
amackillop
force-pushed
the
austin_add-flake-1
branch
from
ccaa875 to
d7467ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up a Nix-based dev environment (fenix + crane) and swaps the husky pre-commit hook for a tracked .githooks directory wired via core.hooksPath.
Husky and lint-staged weren't doing much. The only tracked JS is index.js and index.d.ts, both auto-generated by NAPI-RS with eslint-disable and prettier-ignore at the top. lint-staged was formatting code that opts out of linting, while the Rust source got nothing. The new hook just runs
just check, which runsnix flake check(fmt, clippy, build).Cargo.lock is now tracked. Crane vendors git deps from it so it has to be visible to Nix, and for a library shipped via npm tracking the lockfile is the right call anyway as binaries are produced.
Toolchain is fenix stable, pinned via flake.lock. No rust-toolchain.toml; the flake is the single source of truth. Note that crane's vendor step needs cargo >= 1.91 for
cargo package --exclude-lockfile. Cargo.toml'srust-versionremains the MSRV for downstream consumers.