Update ldk-node and bpi#42
Merged
Merged
Conversation
The new bpi rev pulled reqwest 0.13, whose `rustls` feature forces aws-lc-rs as the rustls crypto provider via cargo feature unification. aws-lc-sys then has to cross-compile its bundled C, which conflicts with the napi-rs docker images on the two gnu Linux targets: - x86_64-unknown-linux-gnu: aws-lc-sys passes `-fuse-ld=lld` to the compiler unconditionally. The image's custom `x86_64-unknown-linux-gnu-gcc` does not recognize the flag, but the image's clang (already CC=clang) does once lld is installed. - aarch64-unknown-linux-gnu: the image's custom cross toolchain at /usr/aarch64-unknown-linux-gnu has a sysroot missing stdatomic.h. Debian's gcc-aarch64-linux-gnu plus libc6-dev-arm64-cross provides the C11 atomics header. The catch is that aws-lc-sys reads TARGET_CC ahead of CC_<target> and CC. The image pre-sets TARGET_CC to its custom gcc, so any CC_<target> exports were ignored until we unset TARGET_CC (and TARGET_CXX, TARGET_AR) first. Same story for CFLAGS on aarch64, which the image pre-sets to the broken sysroot. The alternative was patching bpi to use reqwest's `rustls-no-provider` plus an explicit ring provider, which would have required a runtime CryptoProvider::install_default() call and another upstream fork bump. Keeping rustls's default provider was preferred since the CI fix is self-contained. Musl targets were not failing in the latest run. If they break later the same TARGET_CC unset trick should apply.
amackillop
force-pushed
the
austin_update-ldk-revs
branch
from
601ac11 to
0c3ccd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ldk-node rev is moved to the revision from the main branch. bitcoin-payment-instructions updated to match the transient dependency